Skip to content

Getting rid of get_unused_fd()

Yann Droneaud linux-fsdevel linux-ia64 linuxppc-dev lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest5 patches 2 repliesIn review
  2. v86 patches 11 repliesSuperseded
  3. v76 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v66 patches0 repliesSuperseded
v57 patches2 repliesSuperseded
v47 patches3 repliesSuperseded
v38 patches2 repliesApplied
v210 patches1 replySuperseded
v113 patches13 repliesApplied

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ia64: trivial: replace get_unused_fd() by get_unused_fd_flags(0)arch/ia64/kernel/perfmon.c+1 -10 replies
2/5ppc/cell: trivial: replace get_unused_fd() by get_unused_fd_flags(0)arch/powerpc/platforms/cell/spufs/inode.c+2 -22 replies
3/5binfmt_misc: trivial: replace get_unused_fd() by get_unused_fd_flags(0)fs/binfmt_misc.c+1 -10 replies
4/5file: trivial: replace get_unused_fd() by get_unused_fd_flags(0)fs/file.c+1 -10 replies
5/5file: remove get_unused_fd() macroinclude/linux/file.h+0 -10 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMichael Ellerman
1/5
2/5A-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCHv9 0/5] Getting rid of get_unused_fd()

Hi,

Please find the 9th revision of my patchset to remove get_unused_fd() macro.

In linux-next, tag next-20141013, they're currently:

- 33 calls to fd_install()
with one call part of anon_inode_getfd()
- 27 calls to get_unused_fd_flags()
with one call part of anon_inode_getfd() with another part of get_unused_fd() macro
- 13 calls to anon_inode_getfd()
- 8 calls to anon_inode_getfile()
with one call part of anon_inode_getfd()
- 5 calls to get_unused_fd()

The following patchset replaces the 5 last calls to get_unused_fd() by calls to get_unused_fd_flags(0) and remove the macro so that it won't be used in newer code.

For some detailed background information, please have a look at my previous patchset's cover letter[1].

Changes from patchset v8[1]
- fanotify: enable close-on-exec on events' fd when requested in fanotify_init()
DROPPED: applied upstream, commit 0b37e097a648.
- reduce the amount of explanation in cover letter

[1] http://lkml.kernel.org/r/[email protected]

Yann Droneaud (5):
ia64: trivial: replace get_unused_fd() by get_unused_fd_flags(0) ppc/cell: trivial: replace get_unused_fd() by get_unused_fd_flags(0)
binfmt_misc: trivial: replace get_unused_fd() by

    get_unused_fd_flags(0)

file: trivial: replace get_unused_fd() by get_unused_fd_flags(0)
file: remove get_unused_fd() macro

 arch/ia64/kernel/perfmon.c                | 2 +-
 arch/powerpc/platforms/cell/spufs/inode.c | 4 ++--
 fs/binfmt_misc.c                          | 2 +-
 fs/file.c                                 | 2 +-
 include/linux/file.h                      | 1 -
 5 files changed, 5 insertions(+), 6 deletions(-)
Signature · 1 line
1.9.3