Skip to content

qlcnic: Mailbox refactoring

Himanshu Madhani netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyIn review
  2. v25 patches 1 replySuperseded

Changes in v3 from the cover letter

* Addressed review feedback to use standard return codes for loopback diagnostic test.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qlcnic: Enhance diagnostic loopback error codes.drivers/net/ethernet/qlogic/qlcnic/qlcnic.h drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +1 more+22 -190 replies
2/5qlcnic: Interrupt based driver firmware mailbox mechanismdrivers/net/ethernet/qlogic/qlcnic/qlcnic.h drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h +2 more+388 -210 replies
3/5qlcnic: Replace poll mode mailbox interface with interrupt based mailbox interfacedrivers/net/ethernet/qlogic/qlcnic/qlcnic.h drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h +3 more+232 -2640 replies
4/5qlcnic: Enable mailbox interface in poll mode when interrupts are not availabledrivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c+11 -70 replies
5/5qlcnic: Update version to 5.2.45drivers/net/ethernet/qlogic/qlcnic/qlcnic.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] qlcnic: Mailbox refactoring

From: Himanshu Madhani <[email protected]>

This series contains following patches

o in v2 series, we received feedback on return codes to use standard error codes instead of mixing custom error codes. We have modified patch for loopback diagnostic test to return standard error codes.

o rest of the 3 patches in the series are for mailbox refactoring

Current driver-firmware mailbox interface was operating in polling mode because of some limitations with the earlier versions of 83xx adapter firmware. These issues are resolved now and we are implementing the mailbox interface in interrupt mode.

There are three patches which refactors mailbox handling:
* Interrupt mode mailbox implantation.
* Replace poll mode mailbox interfaces with interrupt mode interfaces.
* Operate mailbox in poll mode when interrupts are not available.

changes from v2 -> v3
* Addressed review feedback to use standard return codes for loopback diagnostic test.

Please consider applying these patches to net-next.

Thanks,
Himanshu

Himanshu Madhani (1):
qlcnic: Update version to 5.2.45

Jitendra Kalsaria (1):
qlcnic: Enhance diagnostic loopback error codes.

Manish Chopra (3):
qlcnic: Interrupt based driver firmware mailbox mechanism
qlcnic: Replace poll mode mailbox interface with interrupt based
mailbox interface
qlcnic: Enable mailbox interface in poll mode when interrupts are not
available

 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h        |  59 +-
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c    | 615 +++++++++++++++------
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h    |  27 +-
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c  |  83 ++-
 .../net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c    |   6 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c     |   6 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |  18 +-
 .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c   | 146 ++---
 8 files changed, 651 insertions(+), 309 deletions(-)
Signature · 1 line
1.8.1.4