RFC Add madvise(..., MADV_WILLWRITE)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | mm: Add MADV_WILLWRITE to indicate that a range will be written toinclude/ include/ mm/ | +41 | 0 replies | |
| 2/3 | fs: Add block_willwritefs/ include/ | +60 | 0 replies | |
| 3/3 | ext4: Implement willwrite for the delalloc casefs/ fs/ fs/ | +25 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/3] Add madvise(..., MADV_WILLWRITE)
My application fallocates and mmaps (shared, writable) a lot (several GB) of data at startup. Those mappings are mlocked, and they live on ext4. The first write to any given page is slow because ext4_da_get_block_prep can block. This means that, to get decent performance, I need to write something to all of these pages at startup. This, in turn, causes a giant IO storm as several GB of zeros get pointlessly written to disk.
This series is an attempt to add madvise(..., MADV_WILLWRITE) to signal to the kernel that I will eventually write to the referenced pages. It should cause any expensive operations that happen on the first write to happen immediately, but it should not result in dirtying the pages.
madvice(addr, len, MADV_WILLWRITE) returns the number of bytes that the operation succeeded on or a negative error code if there was an actual failure. A return value of zero signifies that the kernel doesn't know how to "willwrite" the range and that userspace should implement a fallback.
For now, it only works on shared writable ext4 mappings. Eventually it should support other filesystems as well as private pages (it should COW the pages but not cause swap IO) and anonymous pages (it should COW the zero page if applicable).
The implementation leaves much to be desired. In particular, it generates dirty buffer heads on a clean page, and this scares me.
Thoughts?
Andy Lutomirski (3):
mm: Add MADV_WILLWRITE to indicate that a range will be written to
fs: Add block_willwrite
ext4: Implement willwrite for the delalloc case
fs/buffer.c | 57 ++++++++++++++++++++++++++++++++++ fs/ext4/ext4.h | 2 ++ fs/ext4/file.c | 1 + fs/ext4/inode.c | 22 +++++++++++++ include/linux/buffer_head.h | 3 ++ include/linux/mm.h | 12 +++++++ include/uapi/asm-generic/mman-common.h | 3 ++ mm/madvise.c | 28 +++++++++++++++-- 8 files changed, 126 insertions(+), 2 deletions(-)
Signature · 7 lines
1.8.3.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>