Skip to content

RFC steps to make audit pid namespace-safe

Richard Guy Briggs linux-audit lkml stable 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest0 of 5 patches 0 repliesNew
  2. v2 RFC5 patches 6 repliesSuperseded
  3. v112 patches 38 repliesSuperseded

Patches in v3 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH 0/5][RFC][v3] steps to make audit pid namespace-safe

This patchset is a revival of some of Eric Biederman's work to make audit pid-namespace-safe.

In a couple of places, audit was printing PIDs in the task's pid namespace rather than relative to the audit daemon's pid namespace, which currently is init_pid_ns.

It also allows processes to log audit user messages in their own pid namespaces, which was not previously permitted. Please see:

	https://bugzilla.redhat.com/show_bug.cgi?id=947530
	https://bugs.launchpad.net/ubuntu/+source/vsftpd/+bug/1160372
	https://bugzilla.novell.com/show_bug.cgi?id=786024

Part of the cleanup here involves deprecating task->pid and task->tgid, which should be accessed using their respective helper functions.

See: https://lkml.org/lkml/2013/8/20/638

Richard Guy Briggs (5):
pid: get pid_t ppid of task in init_pid_ns
audit: convert PPIDs to the inital PID namespace.
audit: store audit_pid as a struct pid pointer
audit: anchor all pid references in the initial pid namespace
audit: allow user processes to log from another PID namespace

 drivers/tty/tty_audit.c              |    3 +-
 include/linux/sched.h                |   18 ++++++++++
 kernel/audit.c                       |   59 ++++++++++++++++++++++++----------
 kernel/audit.h                       |    4 +-
 kernel/auditfilter.c                 |   17 +++++++++-
 kernel/auditsc.c                     |   24 +++++++------
 security/integrity/integrity_audit.c |    2 +-
 security/lsm_audit.c                 |   11 ++++--
 8 files changed, 101 insertions(+), 37 deletions(-)