replace genext2fs with populate-extfs.sh
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | e2fsprogs: the max length of debugfs argument is too shortmeta/ meta/ | +42 | 1 reply | |
| 2/6 | e2fsprogs: let debugfs do sparse copymeta/ meta/ | +148 | 6 replies | |
| 3/6 | e2fsprogs: only update the icache for ext2_inodemeta/ meta/ | +70 | 3 replies | |
| 4/6 | e2fsprogs: properly set up extent header in do_writemeta/ meta/ | +49 | 3 replies | |
| 5/6 | e2fsprogs: add populate-extfs.shmeta/ meta/ | +97 | 2 replies | |
| 6/6 | image_types.bbclass: replace genext2fs with populate-extfs.shmeta/ | +18 | 0 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Darren Hart |
|---|---|
| 1/6 | A-b |
| 2/6 | A-b |
| 3/6 | A-b |
| 4/6 | A-b |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] replace genext2fs with populate-extfs.sh
* The benefits:
- Really support ext4
- Support the sparse file (we lost the sparse file in the image in the past, the sparse file became into the common file)
- Fix the error reported by fsck: (ext2/ext3)
"Inode 1025, i_size is 16384, should be 17408."
- Have a uniform code for ext2/3/4 generation
* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 40 extra seconds are needed, here is my test result:
Before the patches: 4m53s
After the patches: 5m35s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.
- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (519M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 356M 379M
ext3: 372M 395M
ext4: 372M 380MI have done some simple runtime testing on core-image-sato based on ext2/3/4, they worked well.
* The "fsck.extX -fn <image>.extX" shows it is OK.
// Robert
The following changes since commit b2ff1add530b1fec2fb7f385227a03db47015c37:
poky.conf: Don't force the addition of extra DISTRO_FEATURES (2013-08-20 22:58:04 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/extX
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/extX
Robert Yang (6):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: only update the icache for ext2_inode
e2fsprogs: properly set up extent header in do_write
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh
meta/classes/image_types.bbclass | 46 +++--- .../e2fsprogs-1.42.8/debugfs-extent-header.patch | 47 +++++++ .../e2fsprogs-1.42.8/debugfs-sparse-copy.patch | 147 ++++++++++++++++++++ .../e2fsprogs-1.42.8/debugfs-too-short.patch | 41 ++++++ .../e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch | 69 +++++++++ .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh | 96 +++++++++++++ .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb | 6 + 7 files changed, 424 insertions(+), 28 deletions(-) create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-extent-header.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-sparse-copy.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-too-short.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
Signature · 1 line
1.7.10.4