Skip to content

Rename nsproxy.pid_ns and fix a related security bug

Andy Lutomirski lkml netdev stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: Check the correct namespace when spoofing pid over SCM_RIGHTSnet/core/scm.c+1 -11 reply
2/2Rename nsproxy.pid_ns to nsproxy.pid_ns_for_childreninclude/linux/nsproxy.h kernel/fork.c kernel/nsproxy.c +1 more+24 -182 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEric W. Biederman
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Rename nsproxy.pid_ns and fix a related security bug

In:

commit 92f28d973cce45ef5823209aab3138eb45d8b349
Author: Eric W. Biederman <[email protected]>
Date: Fri Mar 15 01:03:33 2013 -0700

scm: Require CAP_SYS_ADMIN over the current pidns to spoof pids.

Eric fell for my bogus claim that nsproxy->pid_ns was the current' process's pid ns. This isn't true.

Let's fix the bug and rename pid_ns so that no one gets this wrong again.

Andy Lutomirski (2):
net: Check the correct namespace when spoofing pid over SCM_RIGHTS Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children

 include/linux/nsproxy.h |  6 +++++-
 kernel/fork.c           |  5 +++--
 kernel/nsproxy.c        | 27 ++++++++++++++-------------
 kernel/pid_namespace.c  |  4 ++--
 net/core/scm.c          |  2 +-
 5 files changed, 25 insertions(+), 19 deletions(-)
Signature · 1 line
1.8.3.1