Skip to content

Fscache cleanup and fix

Milosz Tanski ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ceph: Do not leak fscache workqueuefs/ceph/super.c+1 -00 replies
2/2ceph: fscache cleanupfs/ceph/cache.c fs/ceph/cache.h fs/ceph/inode.c +2 more+115 -1280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fscache cleanup and fix

Sage,

These are the changes you requested. I eliminated the use of ifdefs in the C code. It's all self contained in cache.[ch] and in the case of it being disabled becomes a nop.

Also, I found a small bug where we would not free the invalidate queue on unmount. It's split into it's own commit.

Finally, I saw that you had a hard time building it without the kernel flag enabled. So I made sure to test a config with fscache for Ceph disabled right before sping things.

The commits are from my branch (which is based on top of the main testing branch) from my repo:

https://[email protected]/adfin/linux-fs.git branch: wip-ceph-fscache

Best,
- Milosz

Milosz Tanski (2):
ceph: Do not leak fscache workqueue
ceph: fscache cleanup

 fs/ceph/cache.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++-------
 fs/ceph/cache.h | 68 +++++++++++++++++++------------------------
 fs/ceph/inode.c | 61 +-------------------------------------
 fs/ceph/super.c | 22 ++++----------
 fs/ceph/super.h |  1 -
 5 files changed, 115 insertions(+), 127 deletions(-)
Signature · 1 line
1.8.1.2