Skip to content

char: fix segfault on chardev detach

Amit Shah qemu-devel 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 2 repliesSuperseded
  3. v19 patches 3 repliesSuperseded

Changes in v3 from the cover letter

* fix whitespace issues in patch 1

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3char: move backends' io watch tag to CharDriverStateinclude/sysemu/char.h qemu-char.c+40 -380 replies
2/3char: use common function to disable callbacks on chardev closeqemu-char.c+19 -430 replies
3/3char: remove watch callback on chardev detach from frontendqemu-char.c+3 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichael Roth
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/3] char: fix segfault on chardev detach

This series fixes a segfault when a frontend is detached from a chardev while the chardev had a pending callback registered. Further details in patch 3.

Please review.

v3:
* fix whitespace issues in patch 1
v2:
* Move tag property to CharDriverState to simplify everything (Gerd)

Amit Shah (3):
char: move backends' io watch tag to CharDriverState
char: use common function to disable callbacks on chardev close
char: remove watch callback on chardev detach from frontend

 include/sysemu/char.h |  1 +
 qemu-char.c           | 82 +++++++++++++++++++--------------------------------
 2 files changed, 32 insertions(+), 51 deletions(-)
Signature · 1 line
1.8.3.1