Skip to content

RFC i386: add cpu hot remove support

Chen Fan qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest8 patches 2 repliesIn review
  2. v4 RFC10 patches 12 repliesSuperseded
  3. v3 RFC10 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC8 patches6 repliesSuperseded
v1 RFC6 patches4 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8x86: move apic_state field from CPUX86State to X86CPUcpu-exec.c cpus.c hw/i386/kvmvapic.c +7 more+46 -562 replies
2/8x86: add x86_cpu_unrealizefn() for cpu apic removehw/i386/kvm/apic.c hw/intc/apic.c hw/intc/apic_common.c +5 more+95 -10 replies
3/8qmp: add 'cpu-del' command supporthw/i386/pc.c hw/i386/pc_piix.c include/hw/boards.h +4 more+64 -10 replies
4/8qom cpu: rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier'hw/acpi/piix4.c hw/i386/pc.c include/sysemu/sysemu.h +1 more+12 -120 replies
5/8qom cpu: add UNPLUG cpu notifier supporthw/acpi/piix4.c include/qom/cpu.h qom/cpu.c+17 -70 replies
6/8i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.cqom/cpu.c+12 -00 replies
7/8piix4: implement function cpu_status_write() for vcpu ejectioncpus.c hw/acpi/piix4.c hw/i386/acpi-dsdt-cpu-hotplug.dsl +1 more+69 -20 replies
8/8cpus: reclaim allocated vCPU objectscpus.c include/qom/cpu.h include/sysemu/kvm.h +1 more+66 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [Qemu-devel] [RFC qom-next v5 0/8] i386: add cpu hot remove support

Via implementing ACPI standard methods _EJ0 in ACPI table, after Guest OS remove one vCPU online, the fireware will store removed bitmap to QEMU, then QEMU could know to notify the assigned vCPU of exiting. meanwhile, intruduce the QOM command 'cpu-del' to remove vCPU from QEMU itself. currently, this patches only support the cpu deleted sequentially from the last one, and command 'cpu-del' would always delete the last cpu every time. in libvirt, command 'virsh set-vcpus' always add/delete vcpu sequentially, so I think this patches will be OK.

this work is based on Andreas Färber's qom-next branch tree.
git://github.com/afaerber/qemu-next.git

this series patches must be used with KVM patch together.

for KVM patches:

    http://comments.gmane.org/gmane.comp.emulators.kvm.devel/114347

v4-v5: delete command 'cpu-del' argument to remove cpu from the last one rather than specify vcpuid and fix migration bug.

Chen Fan (8):
x86: move apic_state field from CPUX86State to X86CPU
x86: add x86_cpu_unrealizefn() for cpu apic remove
qmp: add 'cpu-del' command support
qom cpu: rename variable 'cpu_added_notifier' to
'cpu_hotplug_notifier'
qom cpu: add UNPLUG cpu notifier support
i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.c
piix4: implement function cpu_status_write() for vcpu ejection
cpus: reclaim allocated vCPU objects

 cpu-exec.c                        |  2 +-
 cpus.c                            | 51 ++++++++++++++++++++++++++++--
 hw/acpi/piix4.c                   | 66 ++++++++++++++++++++++++++++++++-------
 hw/i386/acpi-dsdt-cpu-hotplug.dsl |  6 +++-
 hw/i386/kvm/apic.c                |  8 +++++
 hw/i386/kvmvapic.c                |  8 ++---
 hw/i386/pc.c                      | 38 ++++++++++++++++------
 hw/i386/pc_piix.c                 |  3 +-
 hw/intc/apic.c                    | 10 ++++++
 hw/intc/apic_common.c             | 23 +++++++++++++-
 hw/xen/xen_apic.c                 |  8 +++++
 include/hw/boards.h               |  2 ++
 include/hw/cpu/icc_bus.h          |  1 +
 include/hw/i386/apic_internal.h   |  1 +
 include/hw/i386/pc.h              |  1 +
 include/qom/cpu.h                 | 21 +++++++++++++
 include/sysemu/kvm.h              |  1 +
 include/sysemu/sysemu.h           |  2 +-
 kvm-all.c                         | 25 +++++++++++++++
 qapi-schema.json                  | 10 ++++++
 qmp-commands.hx                   | 21 +++++++++++++
 qmp.c                             |  9 ++++++
 qom/cpu.c                         | 26 ++++++++++++---
 target-i386/cpu-qom.h             |  5 +++
 target-i386/cpu.c                 | 66 ++++++++++++++++++++++++++++++++-------
 target-i386/cpu.h                 |  4 ---
 target-i386/helper.c              |  9 +++---
 target-i386/kvm.c                 | 23 ++++++--------
 target-i386/misc_helper.c         |  8 ++---
 29 files changed, 380 insertions(+), 78 deletions(-)
Signature · 1 line
1.8.1.4