Skip to content

fscache fixes for ceph

Milosz Tanski ceph-devel linux-fsdevel lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ceph: ceph_readpage_to_fscache didn't check if markedfs/ceph/cache.c+3 -00 replies
2/2ceph: page still marked private_2fs/ceph/addr.c fs/ceph/cache.h+14 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] fscache fixes for ceph

On the whole the current iteration of FSCache on Ceph has been quite stable for me. We've had it deployed on 4 clients running for a week in a row. I did run into two small issues.

First one, I wasn't checking if the page was marked with private_2 before asking FSCache to write to it. I've never seen this before and I only seen this issue once.

The second issue is similar to what I was seeing before with pages marked private_2 when we return them to the page cache. In this case the start_read() in addr.c was returning the pages in the error path of the code. I have plugged that issue. I only seen this one a handful of times across all clients.

As usual please apply the changes from repo located at:

https://bitbucket.org/adfin/linux-fs.git branch: wip-ceph-fscache

Cheers,
- Milosz

Milosz Tanski (2):
ceph: ceph_readpage_to_fscache didn't check if marked
ceph: page still marked private_2

 fs/ceph/addr.c  |  1 +
 fs/ceph/cache.c |  3 +++
 fs/ceph/cache.h | 14 +++++++++++++-
 3 files changed, 17 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.1.2