Skip to content

ceph: fscache support & upstream changes

Milosz Tanski ceph-devel linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8FS-Cache: Add interface to check consistency of a cached objectDocumentation/filesystems/caching/backend-api.txt Documentation/filesystems/caching/netfs-api.txt fs/fscache/cookie.c +4 more+152 -280 replies
2/8CacheFiles: Implement interface to check cache consistencyfs/cachefiles/interface.c fs/cachefiles/internal.h fs/cachefiles/xattr.c+63 -00 replies
3/8fscache: Netfs function for cleanup post readpagesDocumentation/filesystems/caching/netfs-api.txt fs/fscache/page.c include/linux/fscache.h+55 -10 replies
4/8ceph: use fscache as a local presisent cachefs/ceph/Kconfig fs/ceph/Makefile fs/ceph/addr.c +7 more+666 -130 replies
5/8ceph: clean PgPrivate2 on returning from readpagesfs/ceph/addr.c fs/ceph/cache.h+9 -00 replies
6/8ceph: ceph_readpage_to_fscache didn't check if markedfs/ceph/cache.c+3 -00 replies
7/8ceph: page still marked private_2fs/ceph/addr.c fs/ceph/cache.h+14 -10 replies
8/8ceph: Do not do invalidate if the filesystem is mounted nofscfs/ceph/cache.c+4 -00 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid Howells
SeriesA-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] ceph: fscache support & upstream changes

Hey gang I think this should be final revision of these changes. The changes are:

* David rewrote the cookie validity check (that originally was written by Hongyi Jia). You might have seen some emails flying about doing it the right way.
* I added crash fix when for Ceph filesystems mounted with nofsc (default) when fscache is compiled into Ceph. Previously it would crash trying to enqueue invalidate checks in the work queue because we didn't initialize if the mount had fscache disabled.

I've tested both changes on my cluster. You can get get these changes from my branch in bitbucket. It contains the upstream wip-fscache branch rebased with David's rewrite of Hongyi Jia's changes.

The branch is located at.

https://bitbucket.org/adfin/linux-fs.git in the wip-fscahce branch

Finally, David requested that this patchset go through the Ceph tree. The tree should have all the proper sign off from David. I also CC'ed him so he can give his final okay.

Best,
- Milosz

David Howells (2):
FS-Cache: Add interface to check consistency of a cached object
CacheFiles: Implement interface to check cache consistency

Milosz Tanski (6):
fscache: Netfs function for cleanup post readpages
ceph: use fscache as a local presisent cache
ceph: clean PgPrivate2 on returning from readpages
ceph: ceph_readpage_to_fscache didn't check if marked
ceph: page still marked private_2
ceph: Do not do invalidate if the filesystem is mounted nofsc

 Documentation/filesystems/caching/backend-api.txt |    9 +
 Documentation/filesystems/caching/netfs-api.txt   |   35 +-
 fs/cachefiles/interface.c                         |   26 ++
 fs/cachefiles/internal.h                          |    1 +
 fs/cachefiles/xattr.c                             |   36 ++
 fs/ceph/Kconfig                                   |    9 +
 fs/ceph/Makefile                                  |    1 +
 fs/ceph/addr.c                                    |   40 ++-
 fs/ceph/cache.c                                   |  400 +++++++++++++++++++++
 fs/ceph/cache.h                                   |  157 ++++++++
 fs/ceph/caps.c                                    |   19 +-
 fs/ceph/file.c                                    |   17 +
 fs/ceph/inode.c                                   |   14 +-
 fs/ceph/super.c                                   |   35 +-
 fs/ceph/super.h                                   |   16 +
 fs/fscache/cookie.c                               |   69 ++++
 fs/fscache/internal.h                             |    6 +
 fs/fscache/page.c                                 |   71 ++--
 include/linux/fscache-cache.h                     |    4 +
 include/linux/fscache.h                           |   42 +++
 20 files changed, 965 insertions(+), 42 deletions(-)
 create mode 100644 fs/ceph/cache.c
 create mode 100644 fs/ceph/cache.h
Signature · 1 line
1.7.9.5