Skip to content

cpufreq: Last minute fixes for 3.12

Viresh Kumar cpufreq linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cpufreq: Remove extra blank linedrivers/cpufreq/cpufreq.c+0 -12 replies
2/5cpufreq: don't break string in print statementsdrivers/cpufreq/cpufreq.c+2 -21 reply
3/5cpufreq: remove __cpufreq_remove_dev()drivers/cpufreq/cpufreq.c+8 -181 reply
4/5cpufreq: don't update policy->cpu while removing while removing other CPUsdrivers/cpufreq/cpufreq.c+3 -21 reply
5/5cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish()drivers/cpufreq/cpufreq.c+7 -714 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchSrivatsa S. BhatStephen Warren
1/5
2/5R-b
3/5R-b
4/5
5/5T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] cpufreq: Last minute fixes for 3.12

Hi Rafael/Srivatsa,

These are some last minute fixes for 3.12. I have found them while looking at the code to fix the latest suspend/resume crashes we see (Reported by Stephen)..

I believe at some place these are behind those crashes, otherwise people with a single cluster or single policy couldn't have faced it.. Like Stephen as he was working on Tegra.

I thought you will wait for my conversation with Srivatsa to get over before actually applying his patches, but saw that just happened :)

No issues, we can talk a bit more about the problems for now and then you can get whatever patches are required for 3.12-rc2

First three of the patchset are minor cleanups (you may or may not take them for 3.12), but last two are some real fixes.. I haven't faced any issue without them but simply found them in code review.

@Stephen: Probably you can try my branch: cpufreq-suspend-fix, which has these patches without Srivatsa's patches (though some bits of those will also be required I believe for multicluster systems)..

--
viresh

Viresh Kumar (5):
cpufreq: Remove extra blank line
cpufreq: don't break string in print statements
cpufreq: remove __cpufreq_remove_dev()
cpufreq: don't update policy->cpu while removing while removing other
CPUs
cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish()

 drivers/cpufreq/cpufreq.c | 50 +++++++++++++++++++----------------------------
 1 file changed, 20 insertions(+), 30 deletions(-)
Signature · 1 line
1.7.12.rc2.18.g61b472e