Skip to content

submodule trailing slash improvements

John Keeping git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 5 repliesIn review

Changes in v2 from the cover letter

* Improvements to existing pathspec code to use is_dir_sep instead of comparing against '/' and handle multiple trailing slashes
* Remove calls to read_cache() made redundant by a new call in builtin/reset.c::parse_args()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pathspec: use is_dir_sep() to check for trailing slashespathspec.c+3 -21 reply
2/4pathspec: strip multiple trailing slashes from submodulespathspec.c+17 -104 replies
3/4rm: re-use parse_pathspec's trailing-slash removalbuiltin/rm.c+4 -160 replies
4/4reset: handle submodule with trailing slashbuiltin/reset.c t/t7400-submodule-basic.sh+10 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] submodule trailing slash improvements

Changes since v1:

* Improvements to existing pathspec code to use is_dir_sep instead of comparing against '/' and handle multiple trailing slashes
* Remove calls to read_cache() made redundant by a new call in builtin/reset.c::parse_args()

John Keeping (4):
pathspec: use is_dir_sep() to check for trailing slashes
pathspec: strip multiple trailing slashes from submodules
rm: re-use parse_pathspec's trailing-slash removal
reset: handle submodule with trailing slash

 builtin/reset.c            |  8 ++++++--
 builtin/rm.c               | 20 ++++----------------
 pathspec.c                 | 30 +++++++++++++++++++-----------
 t/t7400-submodule-basic.sh |  6 ++++--
 4 files changed, 33 insertions(+), 31 deletions(-)
Signature · 1 line
1.8.4.277.gfbd6843.dirty