RFC FPGA subsystem core
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest0 of 1 patch 36 repliesIn review
- v1 RFC0 of 1 patch 0 repliesSuperseded
Changes in v2 from the cover letter
- Remove ! from all error message not to be shouty
- Fix error codes
- Add sysfs-class-fpga description
- Use read/write helper functions with bit protection
- s/fpga_mgr_status_show/fpga_mgr_status_read/g
- Do not all end driver status just show core status
- Extract firmware support to specific sysfs firmware file
- Add support for sysfs bin attributes (fpga_config_state, fpga_config_data)
- Allocate space for name dynamically
- Introduce new flags bits (INIT_DONE, READ, WRITE)
Patches in v2 No applies recorded yet
The patch the cover letter announces is not in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC PATCH v2 0/1] FPGA subsystem core
Hi All,
this is the second attempt to introduce new Linux FPGA subsystem which can help us to unify all fpga drivers which in general do the same things.
Xilinx has hwicap in the kernel as char driver (drivers/char/xilinx_hwicap/) and I would like to base Zynq devcfg driver based on this interface because make no sense to push the Linux kernel another char driver (I am testing this interface on this driver).
Based on my discussion at ELC with Greg KH the new driver should support firmware interface for loading bitstream.
FPGA manager/driver just define set of functions and call fpga_mgr_register().
struct fpga_manager_ops zynq_fpga_mgr_ops = {
.read_init = zynq_init,
.write_init = zynq_init,
.read = zynq_read,
.write = zynq_write,
.read_complete = zynq_complete,
.write_complete = zynq_complete,
};
fpga_mgr_register(pdev, &zynq_fpga_mgr_ops, "Zynq FPGA Manager", priv);
For unregistration it is enough to call:fpga_mgr_unregister(pdev);
Here is the set of commands for writing bitstream to FPGA.
Through firmware interface:
cat /sys/class/fpga_manager/fpga0/name
echo -n fpga.bin > /sys/class/fpga_manager/fpga0/firmware
Through sysfs bin file:
cat /sys/class/fpga_manager/fpga0/fpga_config_state
echo -n write_init > /sys/class/fpga_manager/fpga0/fpga_config_state cat /lib/firmware/fpga.bin > /sys/class/fpga_manager/fpga0/fpga_config_data echo -n write_complete > /sys/class/fpga_manager/fpga0/fpga_config_state
Subsystem supports working with phandles for cases where you want to load bitstreams for particular device through defined device.
For example:
mngr@0 {
compatible = "whatever";
fpga-mgr = <&ps7_dev_cfg_0>;
...
} ;With these lines you can get easily load bitstream to the device.
struct fpga_manager *mgr;
mgr = of_find_fpga_mgr_by_phandle(pdev->dev.of_node, "fpga-mgr"); if (mgr)
mgr->fpga_firmware_write(mgr, "filename");
NOTE: I have added there of_find_fpga_mgr_by_node() and of_find_fpga_mgr_by_phandle() but maybe they should be added separately to drivers/of/of_fpga.c.
Alessandro: I haven't looked at your FMC cases but maybe this could be also worth for your cases.
TODO:
- Probably make sense to create doc in Documentation folder too.
- When interface is fine also send zynq devcfg driver
- Properly test reading (we have problem with zynq devcfg driver now)
- Not sure if firmware interface also provide option to create files from kernel space.
Thanks for your comments,
Michal
Changes in v2:
- Remove ! from all error message not to be shouty
- Fix error codes
- Add sysfs-class-fpga description
- Use read/write helper functions with bit protection
- s/fpga_mgr_status_show/fpga_mgr_status_read/g
- Do not all end driver status just show core status
- Extract firmware support to specific sysfs firmware file
- Add support for sysfs bin attributes (fpga_config_state, fpga_config_data)
- Allocate space for name dynamically
- Introduce new flags bits (INIT_DONE, READ, WRITE)
Michal Simek (1):
fpga: Introduce new fpga subsystem
Documentation/ABI/testing/sysfs-class-fpga | 33 ++ MAINTAINERS | 7 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/fpga/Kconfig | 18 + drivers/fpga/Makefile | 5 + drivers/fpga/fpga-mgr.c | 753 +++++++++++++++++++++++++++++ include/linux/fpga.h | 110 +++++ 8 files changed, 929 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-fpga create mode 100644 drivers/fpga/Kconfig create mode 100644 drivers/fpga/Makefile create mode 100644 drivers/fpga/fpga-mgr.c create mode 100644 include/linux/fpga.h
--
1.8.2.3