Skip to content

qlcnic: ethtool enhancements and code cleanup.

Himanshu Madhani netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 1 replyIn review
  2. v39 patches 1 replySuperseded
  3. v29 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches4 repliesSuperseded

Changes in v4 from the cover letter

o Dropped patch for Tx queue validation to be submitted in net.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8qlcnic: Print informational messages only once during driver load.drivers/net/ethernet/qlogic/qlcnic/qlcnic.h drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c +1 more+22 -160 replies
2/8qlcnic: Enhance ethtool to display ring indices and interrupt maskdrivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c+44 -180 replies
3/8qlcnic: Firmware dump collection when auto recovery is disabled.drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c+17 -10 replies
4/8qlcnic: Update ethtool standard pause settings.drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h+18 -30 replies
5/8qlcnic: Remove redundant eSwitch enable commandsdrivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c+12 -260 replies
6/8qlcnic: dcb code cleanup and refactoring.drivers/net/ethernet/qlogic/qlcnic/qlcnic.h drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c +5 more+207 -2280 replies
7/8qlcnic: Skip unknown entry type while collecting firmware dumpdrivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c+19 -220 replies
8/8qlcnic: update version to 5.3.51drivers/net/ethernet/qlogic/qlcnic/qlcnic.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH net-next v4 0/8] qlcnic: ethtool enhancements and code cleanup.

From: Himanshu Madhani <[email protected]>

This patch series contains

o updates to ethtool for pause settings and enhance register dump to display mask and ring indices.
o cleanup in DCB code and remove redundant eSwitch enablement command.
o fixed firmware dump collection logic to skip unknown entries.

Changes from v3 -> v4
o Dropped patch for Tx queue validation to be submitted in net.

Changes from v2 -> v3

o Updated patch to print informational messages as per Joe Perches's comment.

Changes from v1 -> v2

o Dropped patch to register device if adapter is in FAILED state for more rework.
o Updated patch to display ring indices via ethtool per Ben Hutchings's comment.
o Update patch for DCB cleanup per Stephen Hemminger's comment.

Please apply to net-next.

Thanks,
Himanshu

Himanshu Madhani (1):
qlcnic: update version to 5.3.51

Jitendra Kalsaria (1):
qlcnic: Update ethtool standard pause settings.

Pratik Pujar (2):
qlcnic: Enhance ethtool to display ring indices and interrupt mask
qlcnic: Firmware dump collection when auto recovery is disabled.

Shahed Shaikh (1):
qlcnic: Skip unknown entry type while collecting firmware dump

Sony Chacko (1):
qlcnic: Remove redundant eSwitch enable commands

Sucheta Chakraborty (2):
qlcnic: Print informational messages only once during driver load.
qlcnic: dcb code cleanup and refactoring.

 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h        | 101 +----------
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c    |  40 ++---
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h    |   5 +-
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c  |  20 ++-
 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c  |  47 +++---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c    | 184 ++++++++++-----------
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h    | 109 ++++++++++--
 .../net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c    |  54 ++++--
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c     |   2 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |  45 +++--
 .../net/ethernet/qlogic/qlcnic/qlcnic_minidump.c   |  41 +++--
 .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c   |   9 +-
 12 files changed, 341 insertions(+), 316 deletions(-)
Signature · 1 line
1.8.1.4