Skip to content

Authenc key parsing consolidation

Mathias Krause linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5crypto: authenc - Export key parsing helper functioncrypto/authenc.c include/crypto/authenc.h+41 -190 replies
2/5crypto: authencesn - Simplify key parsingcrypto/authencesn.c+4 -220 replies
3/5crypto: ixp4xx - Simplify and harden key parsingdrivers/crypto/ixp4xx_crypto.c+9 -170 replies
4/5crypto: picoxcell - Simplify and harden key parsingdrivers/crypto/picoxcell_crypto.c+8 -240 replies
5/5crypto: talitos - Simplify key parsingdrivers/crypto/talitos.c+8 -270 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Authenc key parsing consolidation

This series removes the code duplication of authenc key parsing by introducing a common helper function crypto_authenc_extractkeys() in patch 1. Patches 2 to 5 change all remaining places to use the new helper. Patches 3 and 4 also fix potential memory corruptions by ensuring the supplied keys won't overflow there respective buffers.

I was unable to test patches 3 to 5 as I don't have the needed hardware for these devices -- not even a cross compiler for those architectures.

In case patches 3 and 4 are enqueued for stable, patch 1 needs to be as well, as it's a prerequisite for those.

Please apply!

Mathias Krause (5):
crypto: authenc - Export key parsing helper function
crypto: authencesn - Simplify key parsing
crypto: ixp4xx - Simplify and harden key parsing
crypto: picoxcell - Simplify and harden key parsing
crypto: talitos - Simplify key parsing

 crypto/authenc.c                  |   48 +++++++++++++++++++++++--------------
 crypto/authencesn.c               |   26 +++-----------------
 drivers/crypto/ixp4xx_crypto.c    |   26 +++++++-------------
 drivers/crypto/picoxcell_crypto.c |   32 ++++++------------------
 drivers/crypto/talitos.c          |   35 ++++++--------------------
 include/crypto/authenc.h          |   12 ++++++++-
 6 files changed, 70 insertions(+), 109 deletions(-)
Signature · 1 line
1.7.2.5