Revert --valgrind-parallel test option
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | Revert "test-lib: support running tests under valgrind in parallel"t/ | +22 | 0 replies | |
| 2/2 | Revert "test-lib: allow prefixing a custom string before "ok N" etc."t/ | +12 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] Revert --valgrind-parallel test option
These patches remove the --valgrind-parallel=N option that was broken from the outset (shame on me). Peff's judgement at the time that its usefulness would approximately be "meh" turns out to be correct.
What's not in the commit message, but drives part of my reasoning in doing a revert instead of a fix: I did fix it up locally only to notice that it was too slow in this case for what I actually wanted to use it for. The only valgrind-test workflow that I find bearable is to run all the tests in the background under prove (takes hours), and then use the prove output (which says exactly which subtests fail) in --valgrind-only=<subtest>. So the latter is -- again Peff was right -- the really useful thing.
The only consolation is that I apparently didn't break any other use of the test suite -- otherwise it would presumably have been fixed very quickly.
Thomas Rast (2):
Revert "test-lib: support running tests under valgrind in parallel" Revert "test-lib: allow prefixing a custom string before "ok N" etc."
t/test-lib.sh | 133 +++++++++++++++------------------------------------------- 1 file changed, 34 insertions(+), 99 deletions(-)
Signature · 1 line
1.8.4.1.810.g312044e