Skip to content

refactor x86 apic to QOM typing

Chen Fan qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Change apic/kvm/xen to use QOM typinghw/cpu/icc_bus.c hw/i386/kvm/apic.c hw/intc/apic.c +4 more+38 -390 replies
2/3Using CPU_FOREACH() instead of scanning local_apicshw/intc/apic.c include/hw/i386/apic_internal.h+33 -510 replies
3/3x86: move apic_state field from CPUX86State to X86CPUcpu-exec.c cpus.c hw/i386/kvmvapic.c +8 more+50 -600 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH v1 0/3] refactor x86 apic to QOM typing

In order to implement 'cpu-del' in the furture.
at first, needing to refactor x86 apic codes.
this converts apic/kvm/xen 's init() callbacks to realize() and dropping local_apics[] from file hw/intc/apic.c. moving apic_state field from CPUX86State to X86CPU.

Chen Fan (3):
Change apic/kvm/xen to use QOM typing
Using CPU_FOREACH() instead of scanning local_apics
x86: move apic_state field from CPUX86State to X86CPU

 cpu-exec.c                      |  2 +-
 cpus.c                          |  5 +--
 hw/cpu/icc_bus.c                | 17 ---------
 hw/i386/kvm/apic.c              | 10 ++++-
 hw/i386/kvmvapic.c              |  8 ++--
 hw/i386/pc.c                    | 17 ++++-----
 hw/intc/apic.c                  | 84 ++++++++++++++++++++---------------------
 hw/intc/apic_common.c           | 17 ++-------
 hw/xen/xen_apic.c               | 11 +++++-
 include/hw/cpu/icc_bus.h        |  1 -
 include/hw/i386/apic_internal.h |  5 +--
 target-i386/cpu-qom.h           |  4 ++
 target-i386/cpu.c               | 22 +++++------
 target-i386/cpu.h               |  4 --
 target-i386/helper.c            |  9 ++---
 target-i386/kvm.c               | 23 +++++------
 target-i386/misc_helper.c       |  8 ++--
 17 files changed, 109 insertions(+), 138 deletions(-)
Signature · 1 line
1.8.1.4