Skip to content

Fix tests on Windows caused by random CRLF output

Johannes Sixt git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3t5300-pack-object: do not compare binary data using test_cmpt/t5300-pack-object.sh+5 -50 replies
2/3Windows: a test_cmp that is agnostic to random LF <> CRLF conversionst/test-lib-functions.sh t/test-lib.sh+67 -04 replies
3/3tests: undo special treatment of CRLF for Windowst/lib-credential.sh t/t7407-submodule-foreach.sh t/t9001-send-email.sh+0 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix tests on Windows caused by random CRLF output

When git, the executable, invokes a bash script (hooks, scripted git commands, ...), bash writes its output with CRLF. This causes tests to fail because the expected output does not contain CR, only LF.

This fixes the tests by replacing test_cmp with a diff computation that disregards the CR.

Patch 1 replaces test_cmp with cmp when binary data is compared. Patch 2 is the actual fix.
Patch 3 removes some work-arounds that are not necessary anymore.

Johannes Sixt (3):
t5300-pack-object: do not compare binary data using test_cmp
Windows: a test_cmp that is agnostic to random LF <> CRLF conversions
tests: undo special treatment of CRLF for Windows

 t/lib-credential.sh          |  4 ---
 t/t5300-pack-object.sh       | 10 +++----
 t/t7407-submodule-foreach.sh |  4 ---
 t/t9001-send-email.sh        |  1 -
 t/test-lib-functions.sh      | 66 ++++++++++++++++++++++++++++++++++++++++++++
 t/test-lib.sh                |  1 +
 6 files changed, 72 insertions(+), 14 deletions(-)
Signature · 21 lines
1.8.4.33.gd68f7e8

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.