Skip to content

Bootstrap the btrfs_find_item interface

Kelley Nielsen linux-btrfs 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Bootstrap generic btrfs_find_item interfacefs/btrfs/backref.c fs/btrfs/ctree.c fs/btrfs/ctree.h+43 -360 replies
2/3expand btrfs_find_item() to include find_root_ref functionalityfs/btrfs/ctree.c fs/btrfs/inode.c fs/btrfs/root-tree.c+11 -200 replies
3/3expand btrfs_find_item() to include find_orphan_item functionalityfs/btrfs/ctree.c fs/btrfs/disk-io.c fs/btrfs/orphan.c +1 more+17 -350 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJosh Triplett
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Bootstrap the btrfs_find_item interface

There are many btrfs functions that manually search the tree for an item. They all reimplement the same mechanism and differ in the conditions that they use to find the item. Zach Brown proposed creating a new core interface, btrfs_find_item, take the place of these functions, and standardize the search functionality.

This patchset takes the first steps toward the implementation of this core interface. Create a starting point for the interface by moving one of the search functions, __inode_item, to ctree.c and renaming it with the core function name. With the next two patches, eliminate one similar helper function each by replacing their callers with calls to the new core function, and modifying the new core function to ensure it fulfills the purpose of the function being replaced.

Kelley Nielsen (3):
Bootstrap generic btrfs_find_item interface
expand btrfs_find_item() to include find_root_ref functionality expand btrfs_find_item() to include find_orphan_item functionality

 fs/btrfs/backref.c   | 40 ++++------------------------------------
 fs/btrfs/ctree.c     | 43 +++++++++++++++++++++++++++++++++++++++++++
 fs/btrfs/ctree.h     |  2 ++
 fs/btrfs/disk-io.c   |  3 ++-
 fs/btrfs/inode.c     |  6 +++---
 fs/btrfs/orphan.c    | 20 --------------------
 fs/btrfs/root-tree.c | 15 ---------------
 fs/btrfs/tree-log.c  |  3 ++-
 8 files changed, 56 insertions(+), 76 deletions(-)
Signature · 1 line
1.8.1.2