Skip to content

ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260

Arnaud Ebalard linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capablearch/arm/boot/dts/armada-xp-mv78230.dtsi+12 -121 reply
1/2ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable+0 -02 replies
1/2ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable+0 -02 replies
2/2ARM: mvebu: fix second and third PCIe unit of Armada XP mv78260arch/arm/boot/dts/armada-xp-mv78260.dtsi+85 -241 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchThomas Petazzoni
1/2A-b
1/2A-b
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260

Hi,

As discussed earlier, here is a set of two patches fixing Armada XP mv78230 and mv78260 PCIe units definition. AFAICT, the most accurate information available regarding those is the table available on the following page:

http://www.marvell.com/embedded-processors/armada-xp/

First patch is simply a resend of the one Thomas reviewed with my SoB. It fixes mv78230 .dtsi and has been tested on real hardware.

Second patch fixes mv78260 .dtsi to reflect the fact that the two first units are x4 and quad x1 capable, and third (and last) interface is x4 only. This patch has only been compiled and not tested on real hardware. As associated changes are quite error-prone, I think it needs some careful review.

As a side note, Thomas, I noticed one more thing, this time in mv78460 .dtsi when comparing it w/ mv78230 and mv78260 ones. The first address of "assigned-address" property varies in the former for each pcie node:

$ grep assigned-address armada-xp-mv78230.dtsi 
         assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x48000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x4c000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
$ grep assigned-address armada-xp-mv78260.dtsi 
         assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x48000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x4c000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x84000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x88000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x8c000 0 0x2000>;
         assigned-addresses = <0x82000800 0 0x42000 0 0x2000>;
$ grep assigned-address armada-xp-mv78460.dtsi 
         assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
         assigned-addresses = <0x82001000 0 0x44000 0 0x2000>;
         assigned-addresses = <0x82001800 0 0x48000 0 0x2000>;
         assigned-addresses = <0x82002000 0 0x4c000 0 0x2000>;
         assigned-addresses = <0x82002800 0 0x80000 0 0x2000>;
         assigned-addresses = <0x82003000 0 0x84000 0 0x2000>;
         assigned-addresses = <0x82003800 0 0x88000 0 0x2000>;
         assigned-addresses = <0x82004000 0 0x8c000 0 0x2000>;
         assigned-addresses = <0x82004800 0 0x42000 0 0x2000>;
         assigned-addresses = <0x82005000 0 0x82000 0 0x2000>;

I took at Documentation/devicetree/bindings/pci/mvebu-pci.txt but failed to find an answer. Can you explain where the difference comes from?

Cheers,

a+

Arnaud Ebalard (2):
ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable
ARM: mvebu: fix second and third PCIe units of Armada XP mv78260

 arch/arm/boot/dts/armada-xp-mv78230.dtsi |  24 +++----
 arch/arm/boot/dts/armada-xp-mv78260.dtsi | 109 ++++++++++++++++++++++++-------
 2 files changed, 97 insertions(+), 36 deletions(-)
Signature · 1 line
1.8.4.rc3