Skip to content

random: code cleanups

Greg Price lkml 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 12 repliesApplied
  2. v111 patches 10 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9random: fix typos / spelling errors in commentsdrivers/char/random.c+3 -31 reply
2/9random: fix comment on proc_do_uuiddrivers/char/random.c+4 -41 reply
3/9random: fix description of get_random_bytesdrivers/char/random.c+3 -21 reply
4/9random: simplify loop in random_readdrivers/char/random.c+18 -392 replies
5/9random: fix comment on "account"drivers/char/random.c+21 -101 reply
6/9random: simplify accounting logicdrivers/char/random.c+4 -81 reply
7/9random: forget lock in lockless accountingdrivers/char/random.c+0 -41 reply
8/9random: tighten bound on random_read_wakeup_threshdrivers/char/random.c+1 -11 reply
9/9random: simplify accounting codedrivers/char/random.c+10 -173 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] random: code cleanups

This series has my cleanups rebased onto the random.git tree, at v3.11-20-g392a546.

Four of the patches touch comments only. Three simplify code without changing its behavior (total diffstat: 32 insertions, 64 deletions). One drops a use of the lock where it doesn't now protect anything, and one tightens slightly a bound on a sysctl value to avoid a pathological case.

The bugfix that was in v1 was taken care of by Peter in a283b5c45 ("random: allow fractional bits to be tracked").

Cheers,
Greg

Greg Price (9):
random: fix typos / spelling errors in comments
random: fix comment on proc_do_uuid
random: fix description of get_random_bytes
random: simplify loop in random_read
random: fix comment on "account"
random: simplify accounting logic
random: forget lock in lockless accounting
random: tighten bound on random_read_wakeup_thresh
random: simplify accounting code

 drivers/char/random.c | 144 +++++++++++++++++++++-----------------------------
 1 file changed, 60 insertions(+), 84 deletions(-)
Signature · 1 line
1.8.3.2