Skip to content

drm/i915: backlight rewrite

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 28 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13drm/i915: clean up backlight conditional builddrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_panel.c+42 -341 reply
2/13drm/i915: make backlight info per-connectordrivers/gpu/drm/i915/i915_dma.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_suspend.c +2 more+61 -501 reply
3/13drm/i915: make asle notifications update backlight on all connectorsdrivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_opregion.c drivers/gpu/drm/i915/intel_panel.c+18 -301 reply
4/13drm/i915: handle backlight through chip specific functionsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h +1 more+447 -2082 replies
5/13drm/i915: fix gen2-gen3 backlight setdrivers/gpu/drm/i915/intel_panel.c+7 -34 replies
6/13drm/i915: vlv does not have pipe field in backlight registersdrivers/gpu/drm/i915/intel_panel.c+0 -21 reply
7/13drm/i915: move backlight level setting in enable/disable to hooksdrivers/gpu/drm/i915/intel_panel.c+36 -121 reply
8/13drm/i915: use the initialized backlight max value instead of reading itdrivers/gpu/drm/i915/intel_panel.c+24 -213 replies
9/13drm/i915: debug print on backlight registerdrivers/gpu/drm/i915/intel_panel.c+6 -02 replies
10/13drm/i915: gather backlight information at setupdrivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_panel.c+58 -123 replies
11/13drm/i915: do full backlight setup at enable timedrivers/gpu/drm/i915/intel_panel.c+89 -568 replies
12/13drm/i915: nuke get max backlight functionsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_panel.c+0 -1341 reply
13/13drm/i915: do not save/restore backlight registersdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_suspend.c+0 -515 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchImre Deak
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] drm/i915: backlight rewrite

Hi all -

This series is a successor to [1], but with too many changes to list so I'll just consider this v1 of the patches.

This is pretty much a rewrite of our backlight code. Highlights:

* All the platform specific stuff in platform specific functions. The code is much easier to follow, and it will be easier to enable future platforms without breaking old ones all the time.

* Backlight enable writes all the backlight registers based on information retrieved at setup stage. We no longer depend on what's in the registers prior to enable, which should make things more deterministic, and we no longer need to save/restore backlight registers.

* We no longer keep reading max backlight value or combination mode bits etc. from the registers all over the place. All that is based on the initial values read in the setup stage.

TODO:

* If initial setup in registers is bogus, we should try to read the values from VBT and/or try to use sane defaults. (This problem we have already, not introduced by the series.)

I've tested this so far on ILK and IVB, trying carefully keep it working commit by commit to keep things bisectable. More testing across platforms is very much needed. We have a history with backlight...

Also available at backlight-rework branch at [2].

BR,
Jani.

[1] http://mid.gmane.org/[email protected]
[2] git://gitorious.org/jani/drm.git

Jani Nikula (13):
drm/i915: clean up backlight conditional build
drm/i915: make backlight info per-connector
drm/i915: make asle notifications update backlight on all connectors drm/i915: handle backlight through chip specific functions drm/i915: fix gen2-gen3 backlight set
drm/i915: vlv does not have pipe field in backlight registers drm/i915: move backlight level setting in enable/disable to hooks drm/i915: use the initialized backlight max value instead of reading
it
drm/i915: debug print on backlight register
drm/i915: gather backlight information at setup
drm/i915: do full backlight setup at enable time drm/i915: nuke get max backlight functions
drm/i915: do not save/restore backlight registers

 drivers/gpu/drm/i915/i915_dma.c       |    2 +-
 drivers/gpu/drm/i915/i915_drv.h       |   23 +-
 drivers/gpu/drm/i915/i915_suspend.c   |   45 --
 drivers/gpu/drm/i915/intel_display.c  |   11 +-
 drivers/gpu/drm/i915/intel_drv.h      |   14 +-
 drivers/gpu/drm/i915/intel_opregion.c |   43 +-
 drivers/gpu/drm/i915/intel_panel.c    |  819 +++++++++++++++++++++------------
 7 files changed, 566 insertions(+), 391 deletions(-)
Signature · 1 line
1.7.10.4