Skip to content

regulator: tps6586x: add version detection and voltage tables

Stefan Agner linux-arm-kernel linux-tegra lkml 5 versions – Applied

Status from this message: I've applied patch 3/3 only to Tegra's for-3.14/dt branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 11 repliesApplied
  2. v43 patches 21 repliesSuperseded
  3. v33 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches4 repliesSuperseded
v13 patches23 repliesSuperseded

Changes in v5 from the cover letter

- Use variable named version instead of ret

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3mfd: tps6586x: add version detectiondrivers/mfd/tps6586x.c include/linux/mfd/tps6586x.h+49 -87 replies
2/3regulator: tps6586x: add and use correct voltage tablearch/arm/boot/dts/tegra20-colibri-512.dtsi drivers/regulator/tps6586x-regulator.c+76 -213 replies
3/3ARM: tegra: correct Colibri T20 regulator settingsarch/arm/boot/dts/tegra20-colibri-512.dtsi+15 -151 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchMark BrownThierry RedingStephen Warren
1/3R-b A-b
2/3A-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/3] regulator: tps6586x: add version detection and voltage tables

This is the 5th version of this patchset which adds version detection for the tps6586x mfd family. Just discovered a missing null reference check which did not triggered in my tests, sorry about that.

This is required because some regulator versions use different voltage tables. The regulator driver now uses the right voltage table according to the version.

While at it, there are a few other incorrect regulator entries in the device tree, change them accordingly (this patch is new and grew out of a patch with the same name which Lucas Stach posted in July).

Tested on Colibri T20 V1.1 and V1.2 which makes use of diffent version of that regulator.

Changes since v4:
- Use variable named version instead of ret

Changes since v3:
- Check if version specific table is necessary

Changes since v2:
- Avoid moving devm_kzalloc
- Removed reg_ from reg_version
- Moved walk through version dependent tables to find_regulator_info, removed the inline definition. This reduces .o size and encapsulates the logic of finding the right regulator into one function. It comes with a slight code duplication, the table search now appears twice.

Changes since v1:
- Merged DT and driver change (preserves bisectability)
- Use different regulator tables for different regulator version
* This also makes the TPS6586X_ANY version needless
- Replaced enum with defines
- Move version message in a sperate function
- Include regulator bugfix, use correct supply voltage
- Checked all voltages, fix SM0/SM1 (Core/CPU) and LDO6 voltage (VDAC/VI) in another commit
- Rebased on top of v3.13-rc2

Stefan Agner (3):
mfd: tps6586x: add version detection
regulator: tps6586x: add and use correct voltage table
ARM: tegra: correct Colibri T20 regulator settings

 arch/arm/boot/dts/tegra20-colibri-512.dtsi | 34 +++++------
 drivers/mfd/tps6586x.c                     | 50 +++++++++++++---
 drivers/regulator/tps6586x-regulator.c     | 93 ++++++++++++++++++++++++------
 include/linux/mfd/tps6586x.h               |  7 +++
 4 files changed, 140 insertions(+), 44 deletions(-)
Signature · 1 line
1.8.4.2