Skip to content

Fix the problem of implicit bash dependency

[email protected] openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18linux-firmware: de-bash scripts to remove bash dependencymeta/recipes-kernel/linux-firmware/files/0001-linux-firmware-de-bash.patch meta/recipes-kernel/linux-firmware/linux-firmware_git.bb+49 -12 replies
2/18apr: make the dev package rdepend on bashmeta/recipes-support/apr/apr_1.4.8.bb+1 -00 replies
3/18libpam: make libpam-xtests rdepend on bashmeta/recipes-extended/pam/libpam_1.1.6.bb+1 -10 replies
4/18hdparm: make wiper appear before hdparm in PACKAGESmeta/recipes-extended/hdparm/hdparm_9.43.bb+1 -10 replies
5/18lsb: de-bash scripts to remove bash dependencymeta/recipes-extended/lsb/lsb/lsb_killproc meta/recipes-extended/lsb/lsb/lsb_log_message meta/recipes-extended/lsb/lsb/lsb_pidofproc +1 more+4 -40 replies
6/18xz: rdepend on bashmeta/recipes-extended/xz/xz_5.1.3alpha.bb+2 -01 reply
7/18dtc: make dtc-misc rdepend on bashmeta/recipes-kernel/dtc/dtc.inc+1 -00 replies
8/18lsbtest: de-bash script to remove bash dependencymeta/recipes-extended/lsb/lsbtest/LSB_Test.sh+2 -20 replies
9/18libtool: explicitly rdepend on bashmeta/recipes-devtools/libtool/libtool-2.4.2.inc+1 -00 replies
10/18rpm: fix RDEPENDS for rpm-buildmeta/recipes-devtools/rpm/rpm_5.4.9.bb+1 -20 replies
11/18nfs-utils: add bash to RDEPENDSmeta/recipes-connectivity/nfs-utils/nfs-utils_1.2.9.bb+1 -10 replies
12/18apt: explicitly rdepend on bashmeta/recipes-devtools/apt/apt_0.9.9.4.bb+1 -10 replies
13/18gzip: explicitly rdepend on bashmeta/recipes-extended/gzip/gzip.inc+2 -01 reply
14/18pm-utils: explicitly rdepend on bashmeta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb+1 -10 replies
15/18ltp: explicitly rdepend on bashmeta/recipes-extended/ltp/ltp_20130904.bb+1 -10 replies
16/18kconfig-frontends: explicitly rdepend on bashmeta/recipes-devtools/kconfig-frontends/kconfig-frontends_3.12.0.0.bb+1 -00 replies
17/18pax-utils: add bash runtime dependencymeta/recipes-devtools/pax-utils/pax-utils_0.7.bb+2 -00 replies
18/18kernel.bbclass: make kernel-dev explicitly rdepend on bashmeta/classes/kernel.bbclass+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/18] Fix the problem of implicit bash dependency

From: Chen Qi <[email protected]>

If package A has implicit bash dependency but there's no explicit runtime dependency written in its recipe, the rootfs task would fail if A is intalled onto an image which doesn't have installed.

For example, if we add nfs-utils to core-image-minimal via:
IMAGE_INSTALL_append = " nfs-utils"
and then build the image from a clean build (no previously built bash package in the package repo), the build would fail for the reason of lack of bash package.

This patchset is an effort to solve this problem. After this patch, there's no such problem in oe-core. But other layers also needs to be fixed for this problem.

//Chen Qi

P.S.
The bash dependency problem is automatically detected by the following script:

#!/bin/sh

if [ $# -lt 1 ]; then
echo "$0 <rpm repo> [report file]"
exit 1
fi

RPM_REPO="$1"
REPORT_FILE=${2:-bash-deps.report}
echo "Analyzing packages under $RPM_REPO ... "

for pkg in find $RPM_REPO -name "*.rpm"; do

    echo $pkg
    result="`rpm -qp --requires $pkg 2>/dev/null | grep -w bash | sort -u | sed -e 's/[ ]*$//'`"
    if [ "$result" = "/bin/bash" ]; then
    echo "MISS: <$pkg>" >> $REPORT_FILE
    else
    echo "OK: <$pkg>" >> $REPORT_FILE
    fi

done

echo "Done. Report could be found in $REPORT_FILE"

Please refer to https://bugzilla.yoctoproject.org/show_bug.cgi?id=5555 for more info.

The following changes since commit 7b9f4b2cd0fe6dc9a536a2db98ed93ffa8c05a8f:

base/gcc-common: Ensure umask setting is consistent for shared workdir (2013-11-29 11:24:48 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/bash-deps
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/bash-deps

Chen Qi (18):
linux-firmware: de-bash scripts to remove bash dependency
apr: make the dev package rdepend on bash
libpam: make libpam-xtests rdepend on bash
hdparm: make wiper appear before hdparm in PACKAGES
lsb: de-bash scripts to remove bash dependency
xz: rdepend on bash
dtc: make dtc-misc rdepend on bash
lsbtest: de-bash script to remove bash dependency
libtool: explicitly rdepend on bash
rpm: fix RDEPENDS for rpm-build
nfs-utils: add bash to RDEPENDS
apt: explicitly rdepend on bash
gzip: explicitly rdepend on bash
pm-utils: explicitly rdepend on bash
ltp: explicitly rdepend on bash
kconfig-frontends: explicitly rdepend on bash
pax-utils: add bash runtime dependency kernel.bbclass: make kernel-dev explicitly rdepend on bash

 meta/classes/kernel.bbclass                        |    1 +
 meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb        |    2 +-
 .../nfs-utils/nfs-utils_1.2.9.bb                   |    2 +-
 meta/recipes-devtools/apt/apt_0.9.9.4.bb           |    2 +-
 .../kconfig-frontends_3.12.0.0.bb                  |    1 +
 meta/recipes-devtools/libtool/libtool-2.4.2.inc    |    1 +
 meta/recipes-devtools/pax-utils/pax-utils_0.7.bb   |    2 +
 meta/recipes-devtools/rpm/rpm_5.4.9.bb             |    3 +-
 meta/recipes-extended/gzip/gzip.inc                |    2 +
 meta/recipes-extended/hdparm/hdparm_9.43.bb        |    2 +-
 meta/recipes-extended/lsb/lsb/lsb_killproc         |    2 +-
 meta/recipes-extended/lsb/lsb/lsb_log_message      |    2 +-
 meta/recipes-extended/lsb/lsb/lsb_pidofproc        |    2 +-
 meta/recipes-extended/lsb/lsb/lsb_start_daemon     |    2 +-
 meta/recipes-extended/lsb/lsbtest/LSB_Test.sh      |    4 +-
 meta/recipes-extended/ltp/ltp_20130904.bb          |    2 +-
 meta/recipes-extended/pam/libpam_1.1.6.bb          |    2 +-
 meta/recipes-extended/xz/xz_5.1.3alpha.bb          |    2 +
 meta/recipes-kernel/dtc/dtc.inc                    |    1 +
 .../files/0001-linux-firmware-de-bash.patch        |   47 ++++++++++++++++++++
 .../linux-firmware/linux-firmware_git.bb           |    3 +-
 meta/recipes-support/apr/apr_1.4.8.bb              |    1 +
 22 files changed, 73 insertions(+), 15 deletions(-)
 create mode 100644 meta/recipes-kernel/linux-firmware/files/0001-linux-firmware-de-bash.patch
Signature · 1 line
1.7.9.5