Skip to content

Cadence GEM Bugfixes and missing features

Peter Crosthwaite qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 1 replyIn review
  2. v113 patches 21 repliesSuperseded

Changes in v2 from the cover letter

Addressed PMM review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14net/cadence_gem: Implement mac level loopback modehw/net/cadence_gem.c+1 -10 replies
2/14net/cadence_gem: Update DMA rx descriptors as we process themhw/net/cadence_gem.c+16 -170 replies
3/14net/cadence_gem: Don't assert against 0 buffer addresshw/net/cadence_gem.c+0 -90 replies
4/14net/cadence_gem: simplify rx buf descriptor walkinghw/net/cadence_gem.c+9 -280 replies
5/14net/cadence_gem: Prefetch rx descriptors ASAPhw/net/cadence_gem.c+35 -270 replies
6/14net/cadence_gem: Implement RX descriptor match mode flagshw/net/cadence_gem.c+69 -130 replies
7/14net/cadence_gem: Implement SAR match bit in rx deschw/net/cadence_gem.c+2 -00 replies
8/14net/cadence_gem: Implement SAR (de)activationhw/net/cadence_gem.c+23 -40 replies
9/14net/cadence_gem: Add missing VMSTATE_END_OF_LISThw/net/cadence_gem.c+1 -00 replies
10/14net/cadence_gem: Fix rx multi-fragment packetshw/net/cadence_gem.c+1 -10 replies
11/14net/cadence_gem: Fix small packet FCS strippinghw/net/cadence_gem.c+8 -50 replies
12/14net/cadence_gem: Fix register w1c logichw/net/cadence_gem.c+6 -70 replies
13/14net/cadence_gem: Improve can_receive debug printferyhw/net/cadence_gem.c+10 -20 replies
14/14net/cadence_gem: Don't rx packets when no rx buffer availablehw/net/cadence_gem.c+10 -10 replies

Reviews trailers per patch

5 of 14 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/14R-b
2/14R-b
3/14
4/14
5/14
6/14
7/14R-b
8/14
9/14
10/14R-b
11/14
12/14R-b
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH arm-devs v2 00/14] Cadence GEM Bugfixes and missing features

Hi Peter,

This series updated cadence GEM (ethernet in Zynq) with a number of bugfixes and enhancements. Most of this has come out of some stress testing we have done internally.

I have also testing briefly using mainline Linux GEM driver.

root@zynq:~# wget
http://people.debian.org/~aurel32/qemu/arm/debian_lenny_arm_staandard.qcow2
Connecting to proxy.xilinx.com:8080 (149.199.33.100:8080)
debian_lenny_arm_sta  18% |*****                          | 29898k
0:00:21 ETArandom: nonblocking pool is initialized
debian_lenny_arm_sta 100% |*******************************|   157M
0:00:00 ETA
root@zynq:~# md5sum debian_lenny_arm_standard.qcow2
7be70fc105525803fae5e095f5b4ecb5  debian_lenny_arm_standard.qcow2

Regards,
Peter

Changed since v1:
Addressed PMM review

Edgar E. Iglesias (1):
net/cadence_gem: Update DMA rx descriptors as we process them

Peter Crosthwaite (13):
net/cadence_gem: Implement mac level loopback mode net/cadence_gem: Don't assert against 0 buffer address net/cadence_gem: simplify rx buf descriptor walking net/cadence_gem: Prefetch rx descriptors ASAP net/cadence_gem: Implement RX descriptor match mode flags net/cadence_gem: Implement SAR match bit in rx desc net/cadence_gem: Implement SAR (de)activation net/cadence_gem: Add missing VMSTATE_END_OF_LIST net/cadence_gem: Fix rx multi-fragment packets net/cadence_gem: Fix small packet FCS stripping net/cadence_gem: Fix register w1c logic net/cadence_gem: Improve can_receive debug printfery net/cadence_gem: Don't rx packets when no rx buffer available

 hw/net/cadence_gem.c | 278 ++++++++++++++++++++++++++++++++-------------------
 1 file changed, 177 insertions(+), 101 deletions(-)
Signature · 1 line
1.8.4.4