Skip to content

Send: minor cleanups, add RO checks

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: send: clean up dead codefs/btrfs/send.c+8 -500 replies
2/3btrfs: remove unused mnt from send_ctxfs/btrfs/send.c+0 -40 replies
3/3btrfs: Check read-only status of roots during sendfs/btrfs/ctree.h fs/btrfs/ioctl.c fs/btrfs/send.c+79 -32 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Send: minor cleanups, add RO checks

First two patches are trivial cleanups that I've spotted while reading send.c, can be applied independently.

The third patch contains the important bits, safety checks that the subvolumes involved in send do not accidentally lose the RO status. I haven't seen this documented anywhere that this is mandatory, implied from how I assume send works. Please let me know if this is wrong.

David Sterba (3):
btrfs: send: clean up dead code
btrfs: remove unused mnt from send_ctx
btrfs: Check read-only status of roots during send

 fs/btrfs/ctree.h |    6 +++
 fs/btrfs/ioctl.c |   22 +++++++++-
 fs/btrfs/send.c  |  116 +++++++++++++++++++++++++++++-------------------------
 3 files changed, 87 insertions(+), 57 deletions(-)
Signature · 1 line
1.7.9