Remove include/hw/xilinx.h
Status from this message: Applied, thanks Peter.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 1 replyApplied
- v27 of 8 patches 2 repliesSuperseded
- v18 patches 3 repliesSuperseded
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | microblaze/s3adsp_1800: Define macros for irq maphw/ | +6 | 0 replies | |
| 2/8 | ppc/virtex_ml507: Define macros for irq/memory mapshw/ | +11 | 0 replies | |
| 3/8 | microblaze/ml605: Define macros for irq/memory mapshw/ | +12 | 0 replies | |
| 4/8 | xilinx: Inline usages of xilinx_intc_create()hw/ hw/ hw/ +1 more | +18 | 0 replies | |
| 5/8 | xilinx: Inline usages of xilinx_timer_create()hw/ hw/ hw/ +1 more | +20 | 0 replies | |
| 6/8 | xilinx: Inline usage of xilinx_ethlite_create()hw/ include/ | +8 | 0 replies | |
| 7/8 | xilinx: Inline usages of xilinx_axi*_init()hw/ include/ | +19 | 0 replies | |
| 8/8 | xilinx: Delete hw/include/xilinx.hhw/ hw/ hw/ +1 more | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [Qemu-devel] [PATCH microblaze/ppc v3 0/8] Remove include/hw/xilinx.h
Hi Edgar,
This file is written for a very old qdev style of machine description. Remove by inlining all usages of its functions (which is consistent with the modern preference that qdev_initery should be inline and not in cross-board helper functions).
To avoid movement of magic numbers, Define macros for IRQ and memory maps as appropriate. This cleanup comes first, followed by the piecewise removal of xilinx.h.
Regards,
Peter
Peter Crosthwaite (8):
microblaze/s3adsp_1800: Define macros for irq map ppc/virtex_ml507: Define macros for irq/memory maps microblaze/ml605: Define macros for irq/memory maps
xilinx: Inline usages of xilinx_intc_create()
xilinx: Inline usages of xilinx_timer_create()
xilinx: Inline usage of xilinx_ethlite_create()
xilinx: Inline usages of xilinx_axi*_init()
xilinx: Delete hw/include/xilinx.h
hw/microblaze/petalogix_ml605_mmu.c | 55 ++++++++++++++----- hw/microblaze/petalogix_s3adsp1800_mmu.c | 35 ++++++++++--- hw/ppc/virtex_ml507.c | 29 +++++++--- include/hw/xilinx.h | 90 -------------------------------- 4 files changed, 95 insertions(+), 114 deletions(-) delete mode 100644 include/hw/xilinx.h
Signature · 1 line
1.9.0.1.g4196000