Skip to content

Generalise FIFO to more integer types

Peter Crosthwaite qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v22 patches 9 repliesSuperseded
  3. v1 RFC2 patches 0 repliesSuperseded

Changes in v3 from the cover letter

Glueified hot paths to increase performance.
Addressed various minor review comments.
Added PL022 as example client (Markus Review).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4util/fifo: Generalise naming schemehw/char/serial.c hw/net/allwinner_emac.c hw/ssi/xilinx_spi.c +7 more+289 -2880 replies
2/4util/fifo: Generalise for common integer widthshw/char/serial.c hw/net/allwinner_emac.c hw/ssi/xilinx_spi.c +3 more+127 -440 replies
3/4ssi: pl022: Send debug info to stderrhw/ssi/pl022.c+1 -10 replies
4/4ssi: pl022: Convert to use FIFOhw/ssi/pl022.c+42 -590 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] Generalise FIFO to more integer types

There is a utility helper for dealing with 8 bit fifos. This should be applicable to other integer widths as well. These two patches generalise this FIFO to work for 16, 32 and 64 bit ints.

changed since v2:
Glueified hot paths to increase performance.
Addressed various minor review comments.
Added PL022 as example client (Markus Review).
changed since v1:
Rebased to include fifo buffer functionality.

Peter Crosthwaite (4):
util/fifo: Generalise naming scheme
util/fifo: Generalise for common integer widths
ssi: pl022: Send debug info to stderr
ssi: pl022: Convert to use FIFO

 hw/char/serial.c                |  30 +++----
 hw/net/allwinner_emac.c         |  72 +++++++--------
 hw/ssi/pl022.c                  | 103 +++++++++-------------
 hw/ssi/xilinx_spi.c             |  42 ++++-----
 hw/ssi/xilinx_spips.c           |  66 +++++++-------
 include/hw/char/serial.h        |   6 +-
 include/hw/net/allwinner_emac.h |   6 +-
 include/qemu/fifo.h             | 180 +++++++++++++++++++++++++++++++++++++
 include/qemu/fifo8.h            | 160 ---------------------------------
 util/Makefile.objs              |   2 +-
 util/fifo.c                     | 190 ++++++++++++++++++++++++++++++++++++++++
 util/fifo8.c                    | 126 --------------------------
 12 files changed, 525 insertions(+), 458 deletions(-)
 create mode 100644 include/qemu/fifo.h
 delete mode 100644 include/qemu/fifo8.h
 create mode 100644 util/fifo.c
 delete mode 100644 util/fifo8.c
Signature · 1 line
1.9.1.1.gbb9f595