Skip to content

net: Convert aligned memcpy to ether_addr_copy

Joe Perches linux-arch linux-arm-kernel lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/78021q: Use ether_addr_copynet/8021q/vlan.c net/8021q/vlan_dev.c+4 -41 reply
2/7appletalk: Use ether_addr_copynet/appletalk/aarp.c+6 -60 replies
3/7atm: Use ether_addr_copynet/atm/lec.c net/atm/mpc.c+6 -50 replies
4/7caif_usb: Use ether_addr_copynet/caif/caif_usb.c+2 -20 replies
5/7netpoll: Use ether_addr_copynet/core/netpoll.c+2 -20 replies
6/7pktgen: Use ether_addr_copynet/core/pktgen.c+4 -40 replies
7/7dsa: Use ether_addr_copynet/dsa/slave.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] net: Convert aligned memcpy to ether_addr_copy

On Wed, 2014-01-15 at 16:45 -0800, David Miller wrote:
From: Joe Perches <[email protected]>

Quoted 10 lines

Date: Wed, 15 Jan 2014 16:07:58 -0800

Quoted 5 lines

If you want the ones for net-next net/ now (but not for batman-adv, that maybe could use a new function like ether_addr_copy_unaligned) here's a changestat.

Otherwise, I'll wait for the next cycle.

This looks fine, why don't you toss it my way over the weekend as I still have some backlog to process at the moment?

I didn't get that done this weekend, so next cycle for most of net/.

I don't want to introduce any breakage this late and there are possible unaligned memcpy(foo, bar, ETH_ALEN) where one or both of foo/bar are stack pointers where the alignment is hard to verify.

There are also statics declared without __aligned(2) that will need updating.

Maybe ether_addr_copy_unaligned should be added too.

Here are the ones I could easily verify...
No worries if it's this cycle or next.

Joe Perches (7):
8021q: Use ether_addr_copy
appletalk: Use ether_addr_copy
atm: Use ether_addr_copy
caif_usb: Use ether_addr_copy
netpoll: Use ether_addr_copy
pktgen: Use ether_addr_copy
dsa: Use ether_addr_copy

 net/8021q/vlan.c     |  2 +-
 net/8021q/vlan_dev.c |  6 +++---
 net/appletalk/aarp.c | 12 ++++++------
 net/atm/lec.c        |  9 +++++----
 net/atm/mpc.c        |  2 +-
 net/caif/caif_usb.c  |  4 ++--
 net/core/netpoll.c   |  4 ++--
 net/core/pktgen.c    |  8 ++++----
 net/dsa/slave.c      |  2 +-
 9 files changed, 25 insertions(+), 24 deletions(-)
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty