Skip to content

spi: dw: device tree and generic queue support

Baruch Siach linux-spi 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 12 repliesApplied
  2. v25 patches 14 repliesApplied
  3. v1 RFC4 patches 10 repliesSuperseded

Changes in v3 from the cover letter

* Reorder patches:

- Move generic queue migration to the beginning

- Move binding documentation before implementation

* Add a patch removing HAVE_CLK dependency

* Address the comments of Mark Brown:

- Move gpio request to probe() for compatibility with deferred gpio probing

- Extend spi_chip_sel() to handle chip-select deactivation

- devm_gpio_request_one() can't be used in probe() to also set direction and level, because we don't know the desired slave dependent chip-select polarity yet

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5spi: dw: migrate to generic queue infrastructuredrivers/spi/spi-dw.c drivers/spi/spi-dw.h+12 -1790 replies
2/5spi: dw: document device tree bindingDocumentation/devicetree/bindings/spi/spi-dw.txt+24 -02 replies
3/5spi: dw-mmio: add device tree supportdrivers/spi/spi-dw-mmio.c+20 -10 replies
4/5spi: dw: add support for gpio controlled chip selectdrivers/spi/spi-dw-mmio.c drivers/spi/spi-dw.c drivers/spi/spi-dw.h+45 -110 replies
5/5spi: dw-mmio: remove HAVE_CLK build dependecydrivers/spi/Kconfig+1 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] spi: dw: device tree and generic queue support

Unfortunately, I probably have no chance access to thest this series on hardware, I's only compile tested. So I'm sending this as RFC for code review. If this series doesn't get merged, it may be used at least as a starting point for someone with hardware access.

These patches add the following:

* Device tree support for the platform driver (dw-mmio)

* GPIO controlled chip-select implementing the generic SPI GPIO CS binding

* Generic queue migration

Comments are welcome.

v3:
* Reorder patches:

- Move generic queue migration to the beginning

- Move binding documentation before implementation

* Add a patch removing HAVE_CLK dependency

* Address the comments of Mark Brown:

- Move gpio request to probe() for compatibility with deferred gpio probing

- Extend spi_chip_sel() to handle chip-select deactivation

- devm_gpio_request_one() can't be used in probe() to also set direction and level, because we don't know the desired slave dependent chip-select polarity yet

v2:
* Use managed resources for GPIO allocation (Mark Brown)

* Add device tree binding documentation (Mark Brown)

Baruch Siach (5):
spi: dw: migrate to generic queue infrastructure
spi: dw: document device tree binding
spi: dw-mmio: add device tree support
spi: dw: add support for gpio controlled chip select
spi: dw-mmio: remove HAVE_CLK build dependecy

 Documentation/devicetree/bindings/spi/spi-dw.txt |  24 +++
 drivers/spi/Kconfig                              |   2 +-
 drivers/spi/spi-dw-mmio.c                        |  43 ++++-
 drivers/spi/spi-dw.c                             | 201 +++--------------------
 drivers/spi/spi-dw.h                             |  24 ++-
 5 files changed, 102 insertions(+), 192 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/spi-dw.txt
Signature · 6 lines
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html