Skip to content

da9055: Driver initialisation fixes, add DT support

Adam Thomson alsa-devel linux-devicetree lkml 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 16 repliesApplied
  2. v18 patches 10 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/8ASoC: da9055: Fix device registration of PMIC and CODEC devicesdrivers/mfd/da9055-i2c.c sound/soc/codecs/da9055.c+19 -48 replies
2/8ASoC: da9055: Add DT support for CODECDocumentation/devicetree/bindings/sound/da9055.txt sound/soc/codecs/da9055.c+30 -03 replies
3/8mfd: da9055: Add DT support for PMICDocumentation/devicetree/bindings/mfd/da9055.txt drivers/mfd/da9055-i2c.c+81 -02 replies
4/8regulator: da9055: Add DT supportdrivers/regulator/da9055-regulator.c+65 -41 reply
5/8onkey: da9055: Remove use of regmap_irq_get_virq()drivers/input/misc/da9055_onkey.c+0 -10 replies
6/8hwmon: da9055: Remove use of regmap_irq_get_virq()drivers/hwmon/da9055-hwmon.c+0 -41 reply
7/8rtc: da9055: Remove use of regmap_irq_get_virq()drivers/rtc/rtc-da9055.c+3 -10 replies
8/8regulator: da9055: Remove use of regmap_irq_get_virq()drivers/regulator/da9055-regulator.c+3 -11 reply

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchMark Brown
1/8A-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] da9055: Driver initialisation fixes, add DT support

This patch series provides the following updates for DA9055 drivers:

- Fixes an issue with da9055 driver initialisation (conflicting device ids) of PMIC (MFD) and CODEC drivers which means they cannot be used together on the same I2C bus.
- Add initial DT support for DA9055 related drivers, including binding documentation.
- Remove use of regmap_irq_get_virq() in driver probes which was conflicting with use of platform_get_irq_byname(). platform_get_irq_byname() already returns the VIRQ number due to MFD core translation so using regmap_irq_get_virq() on that returned value results in an incorrect IRQ being requested. The driver probes then fail because of this.

[Changes since v1]:

- Regulator:
* fixed coding style issue (lack of braces for if,else statement)
* removal of 'ifdef' around DT related headers
* Use of 'of_regulator_match()' for retrieving regulator related info from DT nodes.

- General:
* Instead of removing platform_get_irq_byname() usage and device resources to fix IRQ conflict in driver probes, now removed 'regmap_irq_get_virq()' as advised. This has been tested on target for both DT and non-DT setups and works as expected.

Adam Thomson (8):
ASoC: da9055: Fix device registration of PMIC and CODEC devices
ASoC: da9055: Add DT support for CODEC
mfd: da9055: Add DT support for PMIC
regulator: da9055: Add DT support
onkey: da9055: Remove use of regmap_irq_get_virq()
hwmon: da9055: Remove use of regmap_irq_get_virq()
rtc: da9055: Remove use of regmap_irq_get_virq()
regulator: da9055: Remove use of regmap_irq_get_virq()

 Documentation/devicetree/bindings/mfd/da9055.txt   |   73 ++++++++++++++++++++
 Documentation/devicetree/bindings/sound/da9055.txt |   22 ++++++
 drivers/hwmon/da9055-hwmon.c                       |    4 -
 drivers/input/misc/da9055_onkey.c                  |    1 -
 drivers/mfd/da9055-i2c.c                           |   20 +++++-
 drivers/regulator/da9055-regulator.c               |   73 ++++++++++++++++++--
 drivers/rtc/rtc-da9055.c                           |    4 +-
 sound/soc/codecs/da9055.c                          |   19 +++++-
 8 files changed, 201 insertions(+), 15 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/da9055.txt
 create mode 100644 Documentation/devicetree/bindings/sound/da9055.txt