Skip to content

More Cadence UART fixes

Peter Crosthwaite qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2char/cadence_uart: Handle qemu_chr_fe_write errorshw/char/cadence_uart.c+5 -21 reply
2/2char/cadence_uart: Add NULL guards against chrhw/char/cadence_uart.c+10 -41 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPeter Maydell
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH target-arm v1 0/2] More Cadence UART fixes

Hi Peter,

Two fixes to Cadence UART. First is a bug in the recently refactored TX code path around error handling.

Second is the long known crashing-cadence-UART bug when there in no backing serial device (i.e. boot a kernel that talks to serial without adding -serial args).

Chris recently reported the second issue to me offline.

Chris,

Please test to see if this a resolution to your issue.

Regards,
Peter

Peter Crosthwaite (2):
char/cadence_uart: Handle qemu_chr_fe_write errors char/cadence_uart: Add NULL guards against chr

 hw/char/cadence_uart.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.5.4