ubs: tegra: two fixes and cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 0 repliesNew
- v43 patches 0 repliesSuperseded
- v33 patches 0 repliesSuperseded
Changes in v5 from the cover letter
- Merged Tegra124 USB header file as well
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | usb: tegra: fix USB2 powerdown for Tegra30 and laterdrivers/ | +3 | 1 reply | |
| 2/3 | usb: tegra: fix PHY configurationarch/ arch/ drivers/ | +27 | 0 replies | |
| 3/3 | usb: tegra: combine header filearch/ arch/ arch/ +4 more | +225 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stephen Warren | Jim Lin |
|---|---|---|
| Series | A-b | |
| 1/3 | A-b T-b | |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH v5 0/3] ubs: tegra: two fixes and cleanup
Only patch 1 is an actual issue while the second patch is something I stumbled upon, and the third is more about housekeeping.
I descieded to ifdef the driver, I think that this is easier to read and does not mix register access style. The function ehci_get_port_speed however don't get a pointer to the usb_ctlr struct and thouse has to work around that. I don't changed the register access style there because of this reason.
The third patch is optional and implements Stephen's suggestion to merge the USB headers. I'm not sure wheater Tegra124 would also profit from this merge, if yes, I think then its definitely worth doing it.
---
Changes since v4:
- Merged Tegra124 USB header file as well
Changes since v3:
- Minor cleanup in USB header file
Changes since v2:
- Split into multiple patches
- Using ifdef to account for differences between Tegra20/Tegra30
- Merging of the header files
Changes since v1:
- Take differences between USBD and other USB ports into account port_sc1
---
Stefan Agner (3):
usb: tegra: fix USB2 powerdown for Tegra30 and later
usb: tegra: fix PHY configuration
usb: tegra: combine header file
arch/arm/include/asm/arch-tegra/usb.h | 223 ++++++++++++++++++++++++- arch/arm/include/asm/arch-tegra114/usb.h | 156 ------------------ arch/arm/include/asm/arch-tegra124/usb.h | 268 ------------------------------- arch/arm/include/asm/arch-tegra20/usb.h | 155 ------------------ arch/arm/include/asm/arch-tegra30/usb.h | 168 ------------------- board/nvidia/common/board.c | 1 - drivers/usb/host/ehci-tegra.c | 28 +++- 7 files changed, 245 insertions(+), 754 deletions(-) delete mode 100644 arch/arm/include/asm/arch-tegra114/usb.h delete mode 100644 arch/arm/include/asm/arch-tegra124/usb.h delete mode 100644 arch/arm/include/asm/arch-tegra20/usb.h delete mode 100644 arch/arm/include/asm/arch-tegra30/usb.h
Signature · 1 line
1.9.0