Skip to content

vDSO fixes, on top of tip/x86/vdso

Andy Lutomirski lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 9 repliesIn review

Changes in v2 from the cover letter

- Adjust CFLAGS instead of using asmlinkage.
- Add more fixes.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86: Use the default ABI for the 32-bit vDSOarch/x86/vdso/Makefile+1 -14 replies
2/4x86: Inline the CLOCK_MONOTONIC vdso codearch/x86/vdso/vclock_gettime.c+1 -10 replies
3/4x86: Patch alternatives in the 32-bit vDSOarch/x86/include/asm/vdso.h arch/x86/vdso/vdso32-setup.c arch/x86/vdso/vma.c+21 -152 replies
4/4x86: Zero-pad the VVAR pagearch/x86/kernel/vmlinux.lds.S+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso

I'd still like someone else to confirm that the 32-bit vDSO is working on all common configurations before I'm happy with it, but this should be a considerable improvement.

Someone who maintains the clock code should review the changes in:

commit 0fc8a237cbe98a06962f5ea37d24fc2369e23c74
Author: Stefani Seibold <[email protected]>
Date: Wed Feb 19 10:09:10 2014 +0100

x86, vdso: Add 32-bit VDSO time support for the 64-bit kernel

very carefully.

There's still something extremely questionable about VDSO_PAGES in the 32-bit vDSO code. It appears to be terminally screwed up, and AFAICS it only works at all because none of the 32-bit vDSO images ever exceed 4096 bytes.

Note: Patch 4 fixes a bug that's present even in -linus, so it might make sense to send it to Linus more quickly than the rest of this series.

Changes from v1:
- Adjust CFLAGS instead of using asmlinkage.
- Add more fixes.

Andy Lutomirski (4):
x86: Use the default ABI for the 32-bit vDSO
x86: Inline the CLOCK_MONOTONIC vdso code
x86: Patch alternatives in the 32-bit vDSO
x86: Zero-pad the VVAR page

 arch/x86/include/asm/vdso.h    |  2 ++
 arch/x86/kernel/vmlinux.lds.S  |  5 +++++
 arch/x86/vdso/Makefile         |  2 +-
 arch/x86/vdso/vclock_gettime.c |  2 +-
 arch/x86/vdso/vdso32-setup.c   | 25 +++++++++++++------------
 arch/x86/vdso/vma.c            |  9 ++++++---
 6 files changed, 28 insertions(+), 17 deletions(-)
Signature · 1 line
1.8.5.3