Skip to content

RFC Fix simple-card *-master DT parameter handling

Jyri Sarha alsa-devel linux-devicetree linux-omap 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest2 patches 10 repliesIn review
  2. v1 RFC2 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: core: Add is_cpu_dai_node-parameter to snd_soc_of_parse_daifmt()include/sound/soc.h sound/soc/soc-core.c+9 -20 replies
2/2ASoC: simple-card: Take snd_soc_of_parse_daifmt() change in to accountsound/soc/generic/simple-card.c+8 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling

Since RFC:
- fixed commit msg typo
- added include/sound/soc.h changes too

The sematics of bitclock-master and frame-master DT parameters should depend on whether they are found from a cpu-dai or codec sub-node.

- bitclock-master in cpu-dai node means Codec-Bitclock-Slave
- frame-master in cpu-dai node means Codec-Frame-Slave
- bitclock-master in codec node means Codec-Bitclock-Master
- frame-master in codec node means Codec-Frame-Master

For example in a cpu-dai mode bitclock-master parameter should produce SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node SND_SOC_DAIFMT_CBM_* flags.

Best regards,
Jyri

Jyri Sarha (2):
ASoC: core: Add is_cpu_dai_node-parameter to
snd_soc_of_parse_daifmt()
ASoC: simple-card: Take snd_soc_of_parse_daifmt() change in to
account

 include/sound/soc.h             |    3 ++-
 sound/soc/generic/simple-card.c |   13 ++++++++-----
 sound/soc/soc-core.c            |    8 +++++++-
 3 files changed, 17 insertions(+), 7 deletions(-)
Signature · 1 line
1.7.9.5

Read the cover letter in its thread