error: Misc cleanups and improvements
Status from this message: Applied to the qmp-next branch, very nice cleanup!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 2 repliesApplied
- v16 patches 17 repliesSuperseded
Changes in v2 from the cover letter
Dropped the error_printf_unless_qmp patch Added the last 4 patches, new cleanups
Use error_report instead of fprintf in patch 1 and 2
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | slirp: Remove default_mon usageslirp/ slirp/ slirp/ | +6 | 0 replies | |
| 2/9 | vnc: Remove default_mon usageui/ | +2 | 0 replies | |
| 3/9 | error: Privatize error_print_locinclude/ util/ | +1 | 0 replies | |
| 4/9 | monitor: Remove unused monitor_print_filenameinclude/ monitor.c stubs/ +1 more | +0 | 0 replies | |
| 5/9 | error: Print error_report() to stderr if using qmputil/ | +1 | 0 replies | |
| 6/9 | qerror.h: Remove unused error classesinclude/ | +0 | 0 replies | |
| 7/9 | qerror.h: Remove QERR defines that are only used onceblock/ blockdev.c hw/ +12 more | +37 | 0 replies | |
| 8/9 | qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTEDblockjob.c include/ stubs/ | +2 | 0 replies | |
| 9/9 | error: Remove some unused headersinclude/ util/ | +1 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paolo Bonzini |
|---|---|
| Series | R-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements
Minor error API cleanups, and one error reporting improvement when connected to qmp (patch #5)
v2:
Dropped the error_printf_unless_qmp patch Added the last 4 patches, new cleanups
Use error_report instead of fprintf in patch 1 and 2
Cole Robinson (9):
slirp: Remove default_mon usage
vnc: Remove default_mon usage
error: Privatize error_print_loc
monitor: Remove unused monitor_print_filename
error: Print error_report() to stderr if using qmp qerror.h: Remove unused error classes
qerror.h: Remove QERR defines that are only used once qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED
error: Remove some unused headers
block/commit.c | 2 +- blockdev.c | 9 ++++-- blockjob.c | 2 +- hw/9pfs/virtio-9p.c | 5 +-- hw/core/qdev-properties.c | 9 +++--- hw/misc/ivshmem.c | 4 +-- include/monitor/monitor.h | 1 - include/qapi/qmp/qerror.h | 79 --------------------------------------------- include/qemu/error-report.h | 1 - monitor.c | 27 ---------------- qapi/qmp-dispatch.c | 3 +- qapi/qmp-input-visitor.c | 2 +- qdev-monitor.c | 12 ++++--- qmp.c | 2 +- qobject/json-parser.c | 2 +- qom/object.c | 5 +-- savevm.c | 3 +- slirp/misc.c | 13 ++------ slirp/slirp.c | 8 ++--- slirp/slirp.h | 2 -- stubs/Makefile.objs | 1 - stubs/arch-query-cpu-def.c | 2 +- stubs/mon-print-filename.c | 6 ---- ui/vnc.c | 4 +-- util/error.c | 5 +-- util/qemu-config.c | 2 +- util/qemu-error.c | 4 +-- util/qemu-option.c | 2 +- 28 files changed, 50 insertions(+), 167 deletions(-) delete mode 100644 stubs/mon-print-filename.c
Signature · 1 line
1.8.5.3