Skip to content

drm/i915: switch to drm core dp aux helpers

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/dp: let drivers specify the name of the I2C-over-AUX adapterdrivers/gpu/drm/drm_dp_helper.c include/drm/drm_dp_helper.h+6 -11 reply
2/6drm/i915/dp: split edp_panel_vdd_on() for reusedrivers/gpu/drm/i915/intel_dp.c+16 -62 replies
3/6drm/i915/dp: move edp vdd enable/disable at a lower level in i2c-over-auxdrivers/gpu/drm/i915/intel_dp.c+6 -31 reply
4/6drm/i915/dp: use the new drm helpers for dp auxdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+116 -1426 replies
5/6drm/i915/dp: move dp aux ch register init to aux initdrivers/gpu/drm/i915/intel_dp.c+22 -202 replies
6/6drm/i915/dp: use the new drm helpers for dp i2c-over-auxdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+30 -1691 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchThierry RedingRodrigo Vivi
1/6R-b R-b
2/6R-b
3/6R-b
4/6
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] drm/i915: switch to drm core dp aux helpers

Switch over to using Thierry's drm dp aux helpers.

The previous RFC series (from before the helpers were merged) is at [1]. I specifically decided to dodge the sleep state issues pointed out by Ville [2] for now; this series does not make us better or worse in this regard.

Only briefly tested on SNB, but seems to work.

Patch 1 has been posted and reviewed on dri-devel already [3], and is included here for completeness.

(These patches demonstrate that git format-patch needs a "function rewrite" option... the diffs in patches 4 and 6 turned out quite hideous with mixed + and - lines.)

BR,
Jani.

[1] http://mid.gmane.org/[email protected]
[2] http://mid.gmane.org/[email protected]
[3] http://mid.gmane.org/[email protected]

Jani Nikula (6):
drm/dp: let drivers specify the name of the I2C-over-AUX adapter drm/i915/dp: split edp_panel_vdd_on() for reuse drm/i915/dp: move edp vdd enable/disable at a lower level in
i2c-over-aux
drm/i915/dp: use the new drm helpers for dp aux drm/i915/dp: move dp aux ch register init to aux init drm/i915/dp: use the new drm helpers for dp i2c-over-aux

 drivers/gpu/drm/drm_dp_helper.c  |    3 +-
 drivers/gpu/drm/i915/intel_dp.c  |  513 ++++++++++++++------------------------
 drivers/gpu/drm/i915/intel_drv.h |    3 +-
 include/drm/drm_dp_helper.h      |    4 +
 4 files changed, 189 insertions(+), 334 deletions(-)
Signature · 1 line
1.7.9.5