Skip to content

Performance improvements for LSI SCSI cards

Matthew Wilcox linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mpt3sas: Remove uses of serial_numberdrivers/scsi/mpt3sas/mpt3sas_base.h drivers/scsi/mpt3sas/mpt3sas_ctl.c drivers/scsi/mpt3sas/mpt3sas_scsih.c+8 -111 reply
2/7mpt3sas: Remove use of DEF_SCSI_QCMDdrivers/scsi/mpt3sas/mpt3sas_scsih.c+3 -62 replies
3/7mpt2sas: Remove uses of serial_numberdrivers/scsi/mpt2sas/mpt2sas_base.h drivers/scsi/mpt2sas/mpt2sas_ctl.c drivers/scsi/mpt2sas/mpt2sas_scsih.c+8 -111 reply
4/7mpt2sas: Remove use of DEF_SCSI_QCMDdrivers/scsi/mpt2sas/mpt2sas_scsih.c+3 -60 replies
5/7mpt2sas: Add free smids to the head, not tail of listdrivers/scsi/mpt2sas/mpt2sas_base.c+4 -41 reply
6/7fusion: Add free msg frames to the head, not tail of listdrivers/message/fusion/mptbase.c+1 -11 reply
7/7fusion: Remove use of DEF_SCSI_QCMDdrivers/message/fusion/mptfc.c drivers/message/fusion/mptsas.c drivers/message/fusion/mptscsih.c +2 more+18 -260 replies

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNicholas BellingerChristoph HellwigPraveen Krishnamoorthy
SeriesR-b R-b
1/7R-b
2/7
3/7R-b
4/7
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] Performance improvements for LSI SCSI cards

The host lock is a serious scalability problem on 2-socket and larger systems which are doing a lot of I/O. Before removing the temporary usgae of DEF_SCSI_QCMD, we need to remove all uses of serial_number.

An unrelated performance issue is that reusing the most recent driver-specific data structure to track the I/O instead of the least recently used keeps the cache-hot lines in use, which is a nice performance improvement. It's already present in the mpt3sas driver, it just didn't make it into the fusion or mpt2sas drivers yet.

Matthew Wilcox (7):
mpt3sas: Remove uses of serial_number
mpt3sas: Remove use of DEF_SCSI_QCMD
mpt2sas: Remove uses of serial_number
mpt2sas: Remove use of DEF_SCSI_QCMD
mpt2sas: Add free smids to the head, not tail of list
fusion: Add free msg frames to the head, not tail of list
fusion: Remove use of DEF_SCSI_QCMD

 drivers/message/fusion/mptbase.c     |  2 +-
 drivers/message/fusion/mptfc.c       | 12 +++++-------
 drivers/message/fusion/mptsas.c      | 10 ++++------
 drivers/message/fusion/mptscsih.c    |  8 +++-----
 drivers/message/fusion/mptscsih.h    |  2 +-
 drivers/message/fusion/mptspi.c      | 12 +++++-------
 drivers/scsi/mpt2sas/mpt2sas_base.c  |  8 ++++----
 drivers/scsi/mpt2sas/mpt2sas_base.h  |  2 +-
 drivers/scsi/mpt2sas/mpt2sas_ctl.c   |  2 +-
 drivers/scsi/mpt2sas/mpt2sas_scsih.c | 24 +++++++++---------------
 drivers/scsi/mpt3sas/mpt3sas_base.h  |  2 +-
 drivers/scsi/mpt3sas/mpt3sas_ctl.c   |  2 +-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 24 +++++++++---------------
 13 files changed, 45 insertions(+), 65 deletions(-)
Signature · 1 line
1.9.0