Skip to content

netlink: per-protocol bind fixup/enhancement set

Richard Guy Briggs linux-audit lkml netdev netfilter-devel selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 3 patches 3 repliesIn review

2 of 3 patches are in this archive. The cover letter announces 3.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3netlink: simplify nfnetlink_bindnet/netfilter/nfnetlink.c+2 -50 replies
3/3netlink: implement unbind to netlink_setsockopt NETLINK_DROP_MEMBERSHIPnet/netlink/af_netlink.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] netlink: per-protocol bind fixup/enhancement set

This set provides a way for per-protocol bind functions to signal an error and to be able to clean up after themselves.

The first patch has already been accepted, but is included just in case to avoid a merge error.

The second patch adds the per-protocol bind return code to signal to the netlink code that no further processing should be done and to undo the work already done. This rev has fixed DaveM's last issue and flattened the intentation as requested by Patrick McHardy by two by reworking the logic.

The third provides a way per protocol to undo actions on DROP.

Thanks for the feedback.

Richard Guy Briggs (3):
netlink: simplify nfnetlink_bind
netlink: have netlink per-protocol bind function return an error code.
netlink: implement unbind to netlink_setsockopt NETLINK_DROP_MEMBERSHIP

 include/linux/netlink.h   |    3 ++-
 net/netfilter/nfnetlink.c |   10 ++++------
 net/netlink/af_netlink.c  |   44 +++++++++++++++++++++++++++++++-------------
 net/netlink/af_netlink.h  |    6 ++++--
 4 files changed, 41 insertions(+), 22 deletions(-)