Skip to content

ACPICA: Fix some mis-ordered inclusions.

Lv Zheng linux-acpi linux-ia64 lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 10 repliesIn review
  2. v14 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ACPICA: OSL: Add direct inclusion of extra header.include/acpi/acpi.h+2 -22 replies
2/5ACPICA: Add <acpi/acpi_opt.h> to remove mis-ordered inclusion of <acpi/actypes.h> from <acpi/platform/aclinux.h>.include/acpi/acpi_opt.h include/acpi/platform/aclinux.h+101 -900 replies
3/5ACPICA: Add <asm/acenv.h> to remove mis-ordered inclusion of <asm/acpi.h> from <acpi/platform/aclinux.h>.arch/ia64/include/asm/acenv.h arch/ia64/include/asm/acpi.h arch/x86/include/asm/acenv.h +2 more+137 -964 replies
4/5ACPICA: Cleanup redudant definitions that already have defaults in <acpi/platform/acenv.h>.arch/ia64/include/asm/acenv.h arch/x86/include/asm/acenv.h include/acpi/platform/aclinux.h+0 -320 replies
5/5ACPICA: Remove deprecated _LINUX definitions for ACPICA.include/linux/acpi.h+0 -44 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] ACPICA: Fix some mis-ordered inclusions.

This patch fixes some mis-ordered inclusions for Linux resident ACPICA.

There is no real issue in the Linux kernel, but this can help to cleanup the code so that (benefits):
1. Redundant environment definitions can be removed from <asm/acpi.h> and <acpi/platform/aclinux.h>.
2. Lift a burden off the ACPICA release automation - copying default ACPICA environment setting to all <asm/acpi.h> file each time a new environment is introduced just in order to avoid build errors.
3. The wrong <acpi/actypes.h> inclusion can be removed from <acpi/platform/aclinux.h>.
4. Using ACPICA defined types in <asm/acpi.h> is possible.
5. Using "static inline" to define ACPICA OSL functions is still possible and won't cause build errors any longer.
6. All non back ported prototypes are collected in a single file.

The patch set has passed the following build/boot tests. Build tests are performed as follows:
1. i386 + default + COFNIG_ACPI=y
2. i386 + default + COFNIG_ACPI=n
3. x86_64 + default + COFNIG_ACPI=y
4. x86_64 + default + COFNIG_ACPI=n
Boot tests are performed as follows:
1. i386 + default + COFNIG_ACPI=y
2. x86_64 + default + COFNIG_ACPI=y
Where:
1. i386: machine named as "Dell Inspiron Mini 1010"
2. x86_64: machine named as "HP Compaq 8200 Elite SFF PC"
3. default: kernel configuration with following items enabled:
All hardware drivers related to the machines of i386/x86_64 All drivers/acpi configurations
All platform drivers
All ACPI drivers
4 DRM drivers that implement ACPI opregion
All buses with ACPI bindings
All cpufreq configurations
All xen configurations
All ACPI tabln drivers

Lv Zheng (5):
ACPICA: OSL: Add direct inclusion of extra header.
ACPICA: Add <acpi/acpi_opt.h> to remove mis-ordered inclusion of
<acpi/actypes.h> from <acpi/platform/aclinux.h>.
ACPICA: Add <asm/acenv.h> to remove mis-ordered inclusion of
<asm/acpi.h> from <acpi/platform/aclinux.h>.
ACPICA: Cleanup redudant definitions that already have defaults in
<acpi/platform/acenv.h>.
ACPICA: Remove deprecated _LINUX definitions for ACPICA.

 arch/ia64/include/asm/acenv.h   |   56 +++++++++++++++++++++
 arch/ia64/include/asm/acpi.h    |   50 -------------------
 arch/x86/include/asm/acenv.h    |   49 ++++++++++++++++++
 arch/x86/include/asm/acpi.h     |   45 -----------------
 include/acpi/acpi.h             |    4 +-
 include/acpi/acpi_opt.h         |   90 +++++++++++++++++++++++++++++++++
 include/acpi/platform/aclinux.h |  104 +++++----------------------------------
 include/linux/acpi.h            |    4 --
 8 files changed, 209 insertions(+), 193 deletions(-)
 create mode 100644 arch/ia64/include/asm/acenv.h
 create mode 100644 arch/x86/include/asm/acenv.h
 create mode 100644 include/acpi/acpi_opt.h
Signature · 1 line
1.7.10