Skip to content

rbd bug fix and discard support

Josh Durgin ceph-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11rbd: access snapshot context and mapping size safelydrivers/block/rbd.c+19 -120 replies
2/11rbd: skip the copyup when an entire object writingdrivers/block/rbd.c+34 -150 replies
3/11rbd: extend the operation typedrivers/block/rbd.c+60 -340 replies
4/11rbd: add discard support for rbddrivers/block/rbd.c+92 -170 replies
5/11rbd: read image size for discard check safelydrivers/block/rbd.c+12 -60 replies
6/11rbd: fix snapshot context reference count for discardsdrivers/block/rbd.c+2 -10 replies
7/11rbd: tolerate -ENOENT for discard operationsdrivers/block/rbd.c+3 -00 replies
8/11rbd: make discard trigger copy-on-writedrivers/block/rbd.c+2 -10 replies
9/11rbd: extract a method for adding object operationsdrivers/block/rbd.c+77 -550 replies
10/11rbd: use helpers to handle discard for layered images correctlydrivers/block/rbd.c+19 -280 replies
11/11rbd: set the remaining discard properties to enable supportdrivers/block/rbd.c+2 -00 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchJosh DurginAlex Elder
1/11
2/11R-b R-b
3/11R-b R-b
4/11R-b R-b
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] rbd bug fix and discard support

The first patch in this series fixes a potential race, which may have been related to http://tracker.ceph.com/issues/7465, though there's not enough information to tell. I put it before the discard-related patches so it could be cherry-picked to older kernels as needed.

The next three patches are rebased versions of Guangliang's discard patches, which have already been reviewd.

The rest are bug fixes which made discard work in my testing for format 1 and layered format 2 images.

Guangliang Zhao (3):
rbd: skip the copyup when an entire object writing
rbd: extend the operation type
rbd: add discard support for rbd

Josh Durgin (8):
rbd: access snapshot context and mapping size safely
rbd: read image size for discard check safely
rbd: fix snapshot context reference count for discards
rbd: tolerate -ENOENT for discard operations
rbd: make discard trigger copy-on-write
rbd: extract a method for adding object operations
rbd: use helpers to handle discard for layered images correctly
rbd: set the remaining discard properties to enable support

 drivers/block/rbd.c |  385 +++++++++++++++++++++++++++++++++++----------------
 1 file changed, 269 insertions(+), 116 deletions(-)
Signature · 1 line
1.7.10.4