Skip to content

tick: cleanups (Shouldn't change code behavior)

Viresh Kumar lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest19 patches 5 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19tick: trivial cleanupsinclude/linux/tick.h kernel/time/clockevents.c kernel/time/clocksource.c +5 more+40 -442 replies
2/19tick: update doc style comments for 'struct tick_sched'include/linux/tick.h+9 -10 replies
3/19tick: rearrange members of 'struct tick_sched'include/linux/tick.h+17 -170 replies
4/19tick: move declaration of 'tick_cpu_device' to tick.hinclude/linux/hrtimer.h include/linux/tick.h kernel/time/tick-internal.h+2 -40 replies
5/19tick: move definition of tick_get_device() to tick.hinclude/linux/tick.h kernel/time/clockevents.c kernel/time/tick-broadcast.c +1 more+15 -170 replies
6/19tick: create tick_get_cpu_device() to get tick_cpu_device on this cpuinclude/linux/tick.h kernel/hrtimer.c kernel/time/tick-broadcast.c +3 more+20 -150 replies
7/19tick: initialize variables during their definitionskernel/time/tick-broadcast.c kernel/time/tick-common.c kernel/time/tick-sched.c+11 -250 replies
8/19tick-oneshot: move tick_is_oneshot_available() to tick-oneshot.cinclude/linux/tick.h kernel/time/tick-common.c kernel/time/tick-internal.h +1 more+16 -150 replies
9/19tick-oneshot: remove tick_resume_oneshot()kernel/time/tick-common.c kernel/time/tick-internal.h kernel/time/tick-oneshot.c+5 -190 replies
10/19tick-common: call tick_check_percpu() from tick_check_preferred()kernel/time/tick-common.c+3 -70 replies
11/19tick-common: remove tick_check_replacement()kernel/time/clockevents.c kernel/time/tick-common.c kernel/time/tick-internal.h+7 -130 replies
12/19tick-common: don't pass 'cpu' & 'cpumask' to tick_setup_device()kernel/time/tick-common.c+5 -50 replies
13/19tick-common: remove local variable 'broadcast' from tick_resume()kernel/time/tick-common.c+7 -80 replies
14/19tick-sched: add comment about 'idle_active' in tick_nohz_idle_exit()kernel/time/tick-sched.c+16 -02 replies
15/19tick-sched: define 'delta' inside 'if' block in update_ts_time_stats()kernel/time/tick-sched.c+2 -30 replies
16/19tick-sched: remove parameters to {__}tick_nohz_task_switch() routinesinclude/linux/tick.h kernel/sched/core.c kernel/time/tick-sched.c+6 -60 replies
17/19tick-sched: remove local variable 'now' from tick_setup_sched_timer()kernel/time/tick-sched.c+1 -30 replies
18/19tick-sched: invert parameter of tick_check_oneshot_change()include/linux/tick.h kernel/hrtimer.c kernel/time/tick-sched.c+9 -90 replies
19/19tick-sched: rearrange code in tick_do_update_jiffies64()kernel/time/tick-sched.c+3 -30 replies

Reviews trailers per patch

1 of 19 patches has a Reviewed-by or Acked-by.

PatchFrederic Weisbecker
1/19
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19A-b
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 00/19] tick: cleanups (Shouldn't change code behavior)

As suggested by you (https://lkml.org/lkml/2014/4/14/797), this is the second lot of changes I have. I have divided the earlier patchset into three parts:
- Bugfixes, already merged
- Code cleanups which shouldn't have any functional change
- Code cleanups which may have any functional change

This patchset is targeting the second part now. Its just about moving the code around to make it more readable and obvious. Not removing any code at all, that will be addressed in next series.

V1->V2: Actually V1 was never reviewed and so it is mostly a resend of V1. Some rearrangement of patches is done though.

Viresh Kumar (19):
tick: trivial cleanups
tick: update doc style comments for 'struct tick_sched'
tick: rearrange members of 'struct tick_sched'
tick: move declaration of 'tick_cpu_device' to tick.h
tick: move definition of tick_get_device() to tick.h
tick: create tick_get_cpu_device() to get tick_cpu_device on this cpu
tick: initialize variables during their definitions
tick-oneshot: move tick_is_oneshot_available() to tick-oneshot.c
tick-oneshot: remove tick_resume_oneshot()
tick-common: call tick_check_percpu() from tick_check_preferred()
tick-common: remove tick_check_replacement()
tick-common: don't pass 'cpu' & 'cpumask' to tick_setup_device()
tick-common: remove local variable 'broadcast' from tick_resume()
tick-sched: add comment about 'idle_active' in tick_nohz_idle_exit()
tick-sched: define 'delta' inside 'if' block in
update_ts_time_stats()
tick-sched: remove parameters to {__}tick_nohz_task_switch() routines
tick-sched: remove local variable 'now' from tick_setup_sched_timer()
tick-sched: invert parameter of tick_check_oneshot_change()
tick-sched: rearrange code in tick_do_update_jiffies64()

 include/linux/hrtimer.h      |  3 --
 include/linux/tick.h         | 62 +++++++++++++++++++-----------
 kernel/hrtimer.c             |  4 +-
 kernel/sched/core.c          |  2 +-
 kernel/time/clockevents.c    | 12 +++---
 kernel/time/clocksource.c    | 14 +++----
 kernel/time/tick-broadcast.c | 48 +++++++++--------------
 kernel/time/tick-common.c    | 90 ++++++++++++++------------------------------
 kernel/time/tick-internal.h  | 15 ++++----
 kernel/time/tick-oneshot.c   | 34 +++++++++--------
 kernel/time/tick-sched.c     | 80 +++++++++++++++++++++++----------------
 kernel/time/timekeeping.c    | 10 ++---
 12 files changed, 177 insertions(+), 197 deletions(-)
Signature · 1 line
1.7.12.rc2.18.g61b472e