Skip to content

staging: crypto: skein: fixing style issues

Anton Saraev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 13 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6staging: crypto: skein: rename camelcase functionsdrivers/staging/skein/TODO drivers/staging/skein/include/skein.h drivers/staging/skein/include/skeinApi.h +10 more+239 -2280 replies
2/6staging: crypto: skein: rename camelcase varsdrivers/staging/skein/TODO drivers/staging/skein/include/skein.h drivers/staging/skein/include/skeinApi.h +10 more+558 -5485 replies
3/6staging: crypto: skein: rename skein1024_ctx to skein_1024_ctxdrivers/staging/skein/include/skein.h drivers/staging/skein/include/skeinApi.h drivers/staging/skein/include/skein_block.h +3 more+17 -170 replies
4/6staging: crypto: skein: rename enumsdrivers/staging/skein/include/skein.h drivers/staging/skein/include/skeinApi.h drivers/staging/skein/include/threefishApi.h +4 more+40 -400 replies
5/6staging: crypto: skein: rename macrosdrivers/staging/skein/include/skein.h drivers/staging/skein/include/skein_iv.h drivers/staging/skein/include/threefishApi.h +5 more+353 -3522 replies
6/6staging: crypto: skein: rename filesdrivers/staging/skein/Makefile drivers/staging/skein/TODO drivers/staging/skein/include/skein_api.h +7 more+14 -164 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchJake Edge
1/6
2/6R-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/06] staging: crypto: skein: fixing style issues

Hi! To prepare skein driver for mainline inclusion we fixing most of style issues (wrong names of functions, vars, macros, files) and checkpatch problems in this patch set. For example, existing code is widely use camelCase names. This patch fix it.

Anton Saraev (6):
staging: crypto: skein: rename camelcase functions
staging: crypto: skein: rename camelcase vars
staging: crypto: skein: rename skein1024_ctx to skein_1024_ctx
staging: crypto: skein: rename enums
staging: crypto: skein: rename macros
staging: crypto: skein: rename files

 drivers/staging/skein/Makefile                     |  10 +-
 drivers/staging/skein/TODO                         |   3 -
 drivers/staging/skein/include/skein.h              | 180 +++----
 .../skein/include/{skeinApi.h => skein_api.h}      |  66 +--
 drivers/staging/skein/include/skein_block.h        |  12 +-
 drivers/staging/skein/include/skein_iv.h           |   6 +-
 .../include/{threefishApi.h => threefish_api.h}    |  84 +--
 drivers/staging/skein/skein.c                      | 577 +++++++++++----------
 drivers/staging/skein/{skeinApi.c => skein_api.c}  | 170 +++---
 drivers/staging/skein/skein_block.c                | 411 +++++++--------
 .../{skeinBlockNo3F.c => skein_block_no_3f.c}      |  62 +--
 drivers/staging/skein/threefishApi.c               |  79 ---
 ...threefish1024Block.c => threefish_1024_block.c} |  80 +--
 .../{threefish256Block.c => threefish_256_block.c} |  32 +-
 .../{threefish512Block.c => threefish_512_block.c} |  48 +-
 drivers/staging/skein/threefish_api.c              |  78 +++
 16 files changed, 959 insertions(+), 939 deletions(-)
 rename drivers/staging/skein/include/{skeinApi.h => skein_api.h} (79%)
 rename drivers/staging/skein/include/{threefishApi.h => threefish_api.h} (66%)
 rename drivers/staging/skein/{skeinApi.c => skein_api.c} (52%)
 rename drivers/staging/skein/{skeinBlockNo3F.c => skein_block_no_3f.c} (66%)
 delete mode 100644 drivers/staging/skein/threefishApi.c
 rename drivers/staging/skein/{threefish1024Block.c => threefish_1024_block.c} (98%)
 rename drivers/staging/skein/{threefish256Block.c => threefish_256_block.c} (96%)
 rename drivers/staging/skein/{threefish512Block.c => threefish_512_block.c} (97%)
 create mode 100644 drivers/staging/skein/threefish_api.c
Signature · 1 line
1.9.2