RFC drm: make drm_get_{connector, encoder}_name thread safe
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | drm: store connector name in connector structdrivers/ include/ | +22 | 3 replies | |
| 2/2 | drm: store encoder name in encoder structdrivers/ include/ | +19 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | David Herrmann |
|---|---|
| Series | A-b |
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/2] drm: make drm_get_{connector, encoder}_name thread safe
Hi all -
This series stores connector/encoder names in the relevant structs to make the name getters thread safe.
What say you, is the wasted memory too high a price to pay for the thread safety and implementation simplicity of this approach? I think making drm_get_connector_name and drm_get_encoder_name return allocated buffers makes a lot of code really ugly and error prone.
I am assuming connector_type, connector_type_id, encoder_type, and encoder.base.id remain unchanged for the lifetime of the connector/encoder - is that a correct assumption?
BR,
Jani.
N.B. I did not actually test this...
Jani Nikula (2):
drm: store connector name in connector struct
drm: store encoder name in encoder struct
drivers/gpu/drm/drm_crtc.c | 67 +++++++++++++++++++++++++--------------------- include/drm/drm_crtc.h | 4 +++ 2 files changed, 41 insertions(+), 30 deletions(-)
Signature · 1 line
1.9.1