Skip to content

Introduce MEN 14F021P00 BMC driver series

Andreas Werner linux-leds linux-watchdog lkml lm-sensors 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 25 repliesIn review
  2. v54 patches 10 repliesSuperseded
  3. v44 patches 12 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches14 repliesSuperseded
v23 patches12 repliesSuperseded
v13 patches8 repliesSuperseded

Changes in v6 from the cover letter

- fixed some style issues (80 chars, whitespaces, alignment)
- fixed error handling in update function of hwmon slave
- fixed whitespace error in hwmon documentation
- added module name in each of the Kconfigs

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driverdrivers/mfd/Kconfig drivers/mfd/Makefile drivers/mfd/menf21bmc.c+148 -01 reply
2/4drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog driverdrivers/watchdog/Kconfig drivers/watchdog/Makefile drivers/watchdog/menf21bmc_wdt.c+214 -05 replies
3/4drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driverdrivers/leds/Kconfig drivers/leds/Makefile drivers/leds/leds-menf21bmc.c+141 -04 replies
4/4drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driverDocumentation/hwmon/menf21bmc drivers/hwmon/Kconfig drivers/hwmon/Makefile +1 more+291 -02 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGuenter RoeckLee JonesBryan Wu
SeriesA-b
1/4A-b
2/4R-b
3/4A-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

This patch set add support for the MEN 14F021P00 Board Management called BMC.

The BMC is a PIC Mikrocontroller which assembled on almost all of our 3U Compact PCI CPU board and a few Box PCs.
main part of the BMC is to start and monitor the board, but there are a lot more features which can be accessed using an I2C Host interface

Features supported in this Patchset:
- Watchdog
- LEDs
- HWMON

The Patchset includes a MFD Core driver, Watchdog, hwmon and LEDs driver.

Changes in v6:
- fixed some style issues (80 chars, whitespaces, alignment)
- fixed error handling in update function of hwmon slave
- fixed whitespace error in hwmon documentation
- added module name in each of the Kconfigs

Changes in v5:
- fixed I2C dependency in MFD Kconfig
- added correct error handling in update function of the hwmon slave (Use of ERR_PTR)
- add ATTRIBUTE_GROUP Macro in hwmon slave
and deleted platform_set_drvdata

Changes in v4:
- fixed some style issues
- fixed GPL license version
- added hwmon voltage monitoring slave driver

Changes in v3:
- deleted i2c_smbus wrapper functions and use native one
- some cosmentics and variable renaming to be more clear
- renamed "leave production" mode to "exit production mode"

Changes in v2:
- changed i2c_smbus_read wrapper function to return both, value and error.
- moved "leave production mode" from Watchdog driver to mfd core.
- fixed some return values in the watchdog driver to return the original error value instead of -EIO.

Andreas Werner (4):
drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver drivers/watchdog/menf21bmc_wdt: introduce MEN 14F021P00 BMC Watchdog
driver
drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

 Documentation/hwmon/menf21bmc    |  50 +++++++++
 drivers/hwmon/Kconfig            |  10 ++
 drivers/hwmon/Makefile           |   1 +
 drivers/hwmon/menf21bmc_hwmon.c  | 230 +++++++++++++++++++++++++++++++++++++++
 drivers/leds/Kconfig             |   9 ++
 drivers/leds/Makefile            |   1 +
 drivers/leds/leds-menf21bmc.c    | 131 ++++++++++++++++++++++
 drivers/mfd/Kconfig              |  15 +++
 drivers/mfd/Makefile             |   1 +
 drivers/mfd/menf21bmc.c          | 132 ++++++++++++++++++++++
 drivers/watchdog/Kconfig         |  10 ++
 drivers/watchdog/Makefile        |   1 +
 drivers/watchdog/menf21bmc_wdt.c | 203 ++++++++++++++++++++++++++++++++++
 13 files changed, 794 insertions(+)
 create mode 100644 Documentation/hwmon/menf21bmc
 create mode 100644 drivers/hwmon/menf21bmc_hwmon.c
 create mode 100644 drivers/leds/leds-menf21bmc.c
 create mode 100644 drivers/mfd/menf21bmc.c
 create mode 100644 drivers/watchdog/menf21bmc_wdt.c
Signature · 1 line
2.0.4