Skip to content

QOMify IRQs

Peter Crosthwaite qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 9 repliesIn review
  2. v14 patches 3 repliesSuperseded

Changes in v2 from the cover letter

Fixed sh4 instance of "[0]" bug (Kirill review)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sdhci: Fix misuse of qemu_free_irqs()hw/sd/sdhci.c+2 -21 reply
2/4hw: Fix qemu_allocate_irqs() leakshw/arm/omap1.c hw/arm/omap2.c hw/arm/pxa2xx.c +11 more+28 -293 replies
3/4irq: Allocate IRQs individuallyhw/char/serial-pci.c hw/core/irq.c hw/core/qdev.c +2 more+11 -170 replies
4/4irq: Slim conversion of qemu_irq to QOMhw/core/irq.c include/hw/irq.h+22 -23 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPeter CrosthwaitePeter MaydellAlberto GarciaKirill BatuzovPaolo Bonzini
1/4R-b R-b
2/4R-b R-b R-b
3/4R-b A-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH qom v2 0/4] QOMify IRQs

Hi Andreas and all,

I have done some cleanup of your WIP IRQ QOMification and have it in a hopefully ready state. Its now link safe and the allocation/freeing process is not as complex as before.

For fuller context of the motivation behind this series, please see:
http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03265.html

changed since v1:
Fixed sh4 instance of "[0]" bug (Kirill review)

Regards,
Peter

Andreas Färber (3):
sdhci: Fix misuse of qemu_free_irqs()
hw: Fix qemu_allocate_irqs() leaks
irq: Slim conversion of qemu_irq to QOM

Peter Crosthwaite (1):
irq: Allocate IRQs individually

 hw/arm/omap1.c          | 14 +++++++-------
 hw/arm/omap2.c          |  2 +-
 hw/arm/pxa2xx.c         |  4 ++--
 hw/arm/spitz.c          |  4 ++--
 hw/arm/z2.c             |  2 +-
 hw/char/serial-pci.c    |  2 +-
 hw/core/irq.c           | 46 +++++++++++++++++++++++++++++-----------------
 hw/core/qdev.c          |  2 +-
 hw/dma/omap_dma.c       |  4 ++--
 hw/ide/microdrive.c     |  2 +-
 hw/ipack/ipack.c        |  2 +-
 hw/misc/cbus.c          |  6 +++---
 hw/pcmcia/pxa2xx.c      |  2 +-
 hw/sd/omap_mmc.c        |  2 +-
 hw/sd/sdhci.c           |  8 ++++----
 hw/sh4/sh7750.c         |  3 +--
 hw/timer/omap_gptimer.c |  4 ++--
 include/hw/irq.h        |  4 +++-
 18 files changed, 63 insertions(+), 50 deletions(-)
Signature · 1 line
2.0.0