ACPI/EC: Critical race fixes.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 2 repliesIn review
- v17 patches 0 repliesSuperseded
Changes in v2 from the cover letter
1. Improves the patch descriptions to make the root cause of the 70891 bug more correct.
2. Improves a race fix to make it more robust.
v2 UPDATE:
Added "Reported-by" and "Tested-by" from kernel bugzilla bug 59911/63931 as a result of EC bug triage. Only patch descriptions are updated. Removed the GPE fix, it is included by another GPE API fix series.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ACPI/EC: Fix an issue that advance_transaction() processes stale hardware status.drivers/ | +6 | 0 replies | |
| 2/6 | ACPI/EC: Add asynchronous command byte write support.drivers/ | +48 | 0 replies | |
| 3/6 | ACPI/EC: Remove duplicated ec_wait_ibf0() waiter.drivers/ | +1 | 0 replies | |
| 4/6 | ACPI/EC: Fix a race condition in ec_transaction_completed().drivers/ | +17 | 0 replies | |
| 5/6 | ACPI/EC: Update revision due to full asynchrnous command support.drivers/ | +9 | 0 replies | |
| 6/6 | ACPI/EC: Add detailed fields debugging support of EC_SC(R).drivers/ | +12 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by.
| Patch | Gareth Williams | Hans de Goede | Arthur Chen | Steffen Weber |
|---|---|---|---|---|
| 1/6 | Reported-and-tested-by | Reported-and-tested-by | T-b | T-b |
| 2/6 | Reported-and-tested-by | Reported-and-tested-by | T-b | T-b |
| 3/6 | Reported-and-tested-by | Reported-and-tested-by | T-b | T-b |
| 4/6 | Reported-and-tested-by | Reported-and-tested-by | T-b | T-b |
| 5/6 | ||||
| 6/6 | T-b | T-b | T-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [UPDATE PATCH v2 0/6] ACPI/EC: Critical race fixes.
History:
v1:
The collection of bug-fixes from kernel bugzilla bug 70891.
v2:
1. Improves the patch descriptions to make the root cause of the 70891 bug more correct.
2. Improves a race fix to make it more robust.
v2 UPDATE:
Added "Reported-by" and "Tested-by" from kernel bugzilla bug 59911/63931 as a result of EC bug triage. Only patch descriptions are updated. Removed the GPE fix, it is included by another GPE API fix series.
This patchset includes the following improvements of the ACPI/EC driver:
1. Fixes 2 race conditions in the current EC driver.
2. Cleans up the first command byte write as one of the race condition fix requires additional cleanup for the first command byte write. And this also helps us to do improvements in the BURST mode in the future.
3. Improves debugging message, register details can be enabled by defining DEBUG. And bug fixes and reports are based on this improvement.
The EC driver is upgraded to v2.2 to indicate the difference from the previous buggy one, so that the future bug reports can be correctly categorized.
All patches are tested to be valid fixes for the following bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=59911
https://bugzilla.kernel.org/show_bug.cgi?id=63931
https://bugzilla.kernel.org/show_bug.cgi?id=70891
Lv Zheng (6):
ACPI/EC: Fix an issue that advance_transaction() processes stale
hardware status.
ACPI/EC: Add asynchronous command byte write support. ACPI/EC: Remove duplicated ec_wait_ibf0() waiter. ACPI/EC: Fix a race condition in ec_transaction_completed(). ACPI/EC: Update revision due to full asynchrnous command support. ACPI/EC: Add detailed fields debugging support of EC_SC(R).
drivers/acpi/ec.c | 159 +++++++++++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 78 deletions(-)
Signature · 1 line
1.7.10