ACPI/EC: Critical bug fixes related to EC and event handling.
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest7 patches 0 repliesNew
Changes in v2 from the cover letter
1. Improves the patch descriptions to make the root cause of the 70891 bug more correct.
2. Improves a race fix to make it more robust.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | ACPI/EC: Fix an issue that advance_transaction() processes stale hardware status.drivers/ | +6 | 0 replies | |
| 2/7 | ACPI/EC: Add asynchronous command byte write support.drivers/ | +48 | 0 replies | |
| 3/7 | ACPI/EC: Remove duplicated ec_wait_ibf0() waiter.drivers/ | +1 | 0 replies | |
| 4/7 | ACPI/EC: Fix a race condition in ec_transaction_completed().drivers/ | +17 | 0 replies | |
| 5/7 | ACPI/EC: Update revision due to full asynchrnous command support.drivers/ | +9 | 0 replies | |
| 6/7 | ACPICA: Events: Fix edge-triggered GPE by disabling before acknowledging it.drivers/ | +17 | 0 replies | |
| 7/7 | ACPI/EC: Add detailed fields debugging support of EC_SC(R).drivers/ | +12 | 0 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by.
| Patch | Gareth Williams | Steffen Weber | Hans de Goede | Arthur Chen |
|---|---|---|---|---|
| Series | Reported-and-tested-by Reported-and-tested-by Reported-and-tested-by Reported-and-tested-by T-b | T-b T-b T-b T-b T-b | Reported-and-tested-by Reported-and-tested-by Reported-and-tested-by Reported-and-tested-by T-b | T-b T-b T-b T-b T-b |
| 1/7 | Reported-and-tested-by | T-b | ||
| 2/7 | Reported-and-tested-by | T-b | ||
| 3/7 | Reported-and-tested-by | T-b | ||
| 4/7 | Reported-and-tested-by | T-b | ||
| 5/7 | ||||
| 6/7 | T-b | T-b | ||
| 7/7 | T-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/7] ACPI/EC: Critical bug fixes related to EC and event handling.
From: Lv Zheng <[email protected]>
History:
v1:
The collection of bug-fixes from kernel bugzilla bug 70891.
v2:
1. Improves the patch descriptions to make the root cause of the 70891 bug more correct.
2. Improves a race fix to make it more robust.
This patchset fixes the following issues:
1. There are 2 race conditions in current EC driver.
2. Cleanup the first command byte write as one of the race condition fix requires additional cleanup for first command byte write. And this also helps us to do improvements in the BURST mode in the future.
3. ACPICA event not handled in the correct way.
This patchset also improves debugging message, register details can be enabled by defining DEBUG. And bug fixes and reports are based on this improvement.
All patches are tested to be valid fixes for the following bug:
https://bugzilla.kernel.org/show_bug.cgi?id=70891
The EC driver version is upgraded to 2.2.
The first 4 patches are useful stable materials. But the culprit of the bug appears so long time ago that patches cannot be applied cleanly any more. Thus 2 commit IDs are listed for the stable reviewers, one for the culprit, the other for the kernel versions that can have these stable materials cleanly applied.
Lv Zheng (7):
ACPI/EC: Fix an issue that advance_transaction() processes stale
hardware status.
ACPI/EC: Add asynchronous command byte write support. ACPI/EC: Remove duplicated ec_wait_ibf0() waiter. ACPI/EC: Fix a race condition in ec_transaction_completed(). ACPI/EC: Update revision due to full asynchrnous command support.
ACPICA: Events: Fix edge-triggered GPE by disabling before
acknowledging it.
ACPI/EC: Add detailed fields debugging support of EC_SC(R).
drivers/acpi/acpica/evgpe.c | 32 +++++---- drivers/acpi/ec.c | 159 ++++++++++++++++++++++--------------------- 2 files changed, 98 insertions(+), 93 deletions(-)
Signature · 1 line
1.7.10