add strnncmp() function
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 11 repliesIn review
- v13 patches 4 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | add strnncmp() functionstrbuf.c strbuf.h | +11 | 6 replies | |
| 2/3 | tree-walk: simplify via strnncmp()tree-walk.c | +3 | 0 replies | |
| 3/3 | unpack-trees: simplify via strnncmp()unpack-trees.c | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] add strnncmp() function
Add a strnncmp() function which behaves like strncmp() except it takes the length of both strings instead of just one.
Then simplify tree-walk.c and unpack-trees.c using this new function. Replace all occurrences of name_compare() with strnncmp(). Remove name_compare(), which they both had identical copies of.
Version 2 includes suggestions from Jonathan Neider [1]:
- Fix the logic which caused the new strnncmp() to behave differently from the old version. Now it is identical to strncmp().
- Improve description of strnncmp().
Also, strnncmp() was switched from using memcmp() to strncmp() internally to make it clear that this is meant for strings, not general buffers.
[1]: http://marc.info/?l=git&m=140294981320743&w=2
Jeremiah Mahler (3):
add strnncmp() function
tree-walk: simplify via strnncmp()
unpack-trees: simplify via strnncmp()
strbuf.c | 9 +++++++++ strbuf.h | 2 ++ tree-walk.c | 16 +++------------- unpack-trees.c | 13 +------------ 4 files changed, 15 insertions(+), 25 deletions(-)
Signature · 1 line
2.0.0.695.g38ee9a9